You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/25 17:06:21 UTC

[GitHub] [camel] oscerd commented on pull request #5127: Xref Alignment

oscerd commented on pull request #5127:
URL: https://github.com/apache/camel/pull/5127#issuecomment-786056226


   This has been voted and merged as template. If you feel it must be removed,
   open an issue, or start a discussion. I'm not against removing it, but
   sometimes it doesn't make sense for small PRs. I usually remove it, this
   time i forgot about it.
   
   Il gio 25 feb 2021, 17:53 djencks <no...@github.com> ha scritto:
   
   > I’d really appreciate it if everyone would remove this boilerplate before
   > creating a PR. If you fill it in that’s (possibly) one thing, but just
   > leaving it in place effectively spams the list with a lot of useless
   > verbiage. An actual description of what the PR does would be really nice,
   > but reproducing this nonsense is really annoying and time consuming to wade
   > through.
   >
   > I think some projects might have found a way to have this kind of verbiage
   > as a comment in the template, so the instructions are there when you’re
   > creating the PR but then disappear once it is created.
   >
   > thanks
   > David Jencks
   >
   > > On Feb 25, 2021, at 1:58 AM, Andrea Cosentino <no...@github.com>
   > wrote:
   > >
   > > Make sure there is a JIRA issue <
   > https://issues.apache.org/jira/browse/CAMEL> filed for the change
   > (usually before you start working on it). Trivial changes like typos do not
   > require a JIRA issue. Your pull request should address just this issue,
   > without pulling in other changes.
   > > Each commit in the pull request should have a meaningful subject line
   > and body.
   > > If you're unsure, you can format the pull request title like [CAMEL-XXX]
   > Fixes bug in camel-file component, where you replace CAMEL-XXX with the
   > appropriate JIRA issue.
   > > Write a pull request description that is detailed enough to understand
   > what the pull request does, how, and why.
   > > Run mvn clean install -Psourcecheck in your module with source check
   > enabled to make sure basic checks pass and there are no checkstyle
   > violations. A more thorough check will be performed on your pull request
   > automatically.
   > > Below are the contribution guidelines:
   > > https://github.com/apache/camel/blob/master/CONTRIBUTING.md <
   > https://github.com/apache/camel/blob/master/CONTRIBUTING.md>
   > > <SNIP>
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/camel/pull/5127#issuecomment-786047415>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABG6XV3REGER3OTN6JAMGR3TAZ6B3ANCNFSM4YGF6GQA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org