[GitHub] RosterIn commented on issue #4802: [AIRFLOW-3978] - Add TIME, BINARY, VARBINARY to MySqlToGoogleCloudStorageOperator

[GitBox <gi...@apache.org>]

RosterIn commented on issue #4802: [AIRFLOW-3978] - Add TIME, BINARY, VARBINARY to MySqlToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/4802#issuecomment-469000730
 
 
   @XD-DENG @feng-tao If you can please let me know what is needed to add support for : TIME, BINARY, VARBINARY types.  I don't have time to refactor this whole operator so I'm looking for a working patch here... 
   
   @methane  This operator gets a SQL query and transfer data from MySQL to Google Storage (Json file).
   so according to your answer  I might be able to avoid the issue completly if the query will convert the problematic types to simple types as this is what the lib does anyway (?) 
   
   so if my table is:
   ```
   CREATE TABLE `my_table` (
   `id` bigint(10) unsigned NOT NULL AUTO_INCREMENT,
   `config_id` binary(8) NOT NULL,
   `my_ip` varbinary(16) NOT NULL,
   PRIMARY KEY (`id`)
   )
   ```
   
   and my query will be: 
   ```
   select id, CAST(config_id AS varchar()), CAST(my_ip AS varchar())
   from my_table
   ```
   It should work doesn't it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services