You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2025/09/28 12:08:20 UTC
[PR] SOLR-17934: Remove Request ID based tracing [solr]
epugh opened a new pull request, #3709:
URL: https://github.com/apache/solr/pull/3709
https://issues.apache.org/jira/browse/SOLR-17934
# Description
Remove Request ID
# Solution
I thought it would be more intrusive to remove this, seems pretty straingt forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3709:
URL: https://github.com/apache/solr/pull/3709#issuecomment-3444047787
> @dsmiley is it possible that part of the scope of this is to remove the `CommonParams.TRACK` property? The comment for it is `value indicating an interest in debug output related to the distributed tracking`, and I THINK by removing the request id, we have gutted what the TRACK had. I noticed it's not documented either in the ref guide, unlike some other values: https://solr.apache.org/guide/solr/latest/query-guide/common-query-parameters.html#debug-parameter. I can't really figure out how to get that one test to pass that is failing without providing some sort of dummy value in the track?
I dug more, and it looks like that is how we track various bits of data when going to various shards... Maybe the `org.apache.solr.client.solrj.impl.CloudSolrClientRoutingTest#routeParamHandling` is no longer needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3709:
URL: https://github.com/apache/solr/pull/3709#issuecomment-3465740666
Just a quick thought -- it may be helpful to go back to the commit that added this (I remember; it was Jason and I was looking at it), and see what it touched exactly. It's so long ago that a revert will unlikely be suitable but that's fine. If that doesn't readily uncover a fix to whatever is stuck here, just LMK and I'll debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3709:
URL: https://github.com/apache/solr/pull/3709#issuecomment-3443742005
@dsmiley is it possible that part of the scope of this is to remove the `CommonParams.TRACK` property? The comment for it is `value indicating an interest in debug output related to the distributed tracking`, and I THINK by removing the request id, we have gutted what the TRACK had. I noticed it's not documented either in the ref guide, unlike some other values: https://solr.apache.org/guide/solr/latest/query-guide/common-query-parameters.html#debug-parameter. I can't really figure out how to get that one test to pass that is failing without providing some sort of dummy value in the track?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3709:
URL: https://github.com/apache/solr/pull/3709#issuecomment-3344071675
Changes seem fine.
I see a test failure:
org.apache.solr.client.solrj.impl.CloudSolrClientRoutingTest#routeParamHandling
```java.lang.NullPointerException: Cannot invoke "org.apache.solr.common.util.NamedList.get(String)" because the return value of "org.apache.solr.common.util.NamedList.get(String)" is null
2> at org.apache.solr.handler.component.DebugComponent.handleResponses(DebugComponent.java:196)
2> java.lang.NullPointerException: Cannot invoke "org.apache.solr.common.util.NamedList.get(String)" because the return value of "org.apache.solr.common.util.NamedList.get(String)" is null
2> at org.apache.solr.handler.component.DebugComponent.handleResponses(DebugComponent.java:196) ~[main/:?]
2> at org.apache.solr.handler.component.SearchHandler.processComponents(SearchHandler.java:657) ~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3709:
URL: https://github.com/apache/solr/pull/3709#issuecomment-3611956156
@dsmiley I've poked again at this, and I would love fresh eyes on this.... Would you be willing to take a look? It's so close...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17934: Remove Request ID based tracing [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #3709:
URL: https://github.com/apache/solr/pull/3709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org