You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/06 08:49:55 UTC
[GitHub] [yunikorn-core] wilfred-s opened a new pull request, #467: [YUNIKORN-1448] partition: remove reservation counter
wilfred-s opened a new pull request, #467:
URL: https://github.com/apache/yunikorn-core/pull/467
### What is this PR for?
Remove the unneeded reservation counter from the partition. Cleanup the logic for node removal and fix a data race in the removal of the reservations from an app.
Update the queue reservations on node removal.
### What type of PR is it?
* [X] - Improvement
### What is the Jira issue?
* https://issues.apache.org/jira/browse/YUNIKORN-1448
### How should this be tested?
existing tests cover it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #467: [YUNIKORN-1448] partition: remove reservation counter
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #467:
URL: https://github.com/apache/yunikorn-core/pull/467#issuecomment-1338983215
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#467](https://codecov.io/gh/apache/yunikorn-core/pull/467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a744f09) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/43553e8ee41a1350e83cc435b452537088d34b83?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43553e8) will **increase** coverage by `0.07%`.
> The diff coverage is `47.82%`.
```diff
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 72.74% 72.81% +0.07%
==========================================
Files 67 67
Lines 10057 10011 -46
==========================================
- Hits 7316 7290 -26
+ Misses 2495 2478 -17
+ Partials 246 243 -3
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `30.32% <ø> (+0.35%)` | :arrow_up: |
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `80.33% <0.00%> (-1.16%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `77.74% <57.14%> (+0.64%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `85.20% <100.00%> (ø)` | |
| [pkg/scheduler/objects/reservation.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3Jlc2VydmF0aW9uLmdv) | `100.00% <100.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `77.28% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #467: [YUNIKORN-1448] partition: remove reservation counter
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #467: [YUNIKORN-1448] partition: remove reservation counter
URL: https://github.com/apache/yunikorn-core/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org