You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "NewSmoke38 (via GitHub)" <gi...@apache.org> on 2025/12/30 00:07:32 UTC
[PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
NewSmoke38 opened a new pull request, #59916:
URL: https://github.com/apache/airflow/pull/59916
I modified the Drill provider to safely handle the absence of `sqlalchemy` by wrapping the import in a try-except block. It now raises `AirflowOptionalProviderFeatureException` in `get_conn` if the library is missing when actually needed.
**Testing:**
I verified this manually by running a script that simulates a missing `sqlalchemy` environment. This confirmed that while the parent `DbApiHook` typically relies on `sqlalchemy`, the Drill provider now loads successfully without it and only raises the correct exception when `get_conn` is called.
I look forward to your feedback.
closes: #59897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #59916:
URL: https://github.com/apache/airflow/pull/59916#issuecomment-3698746907
I am actually not sure whether we need this PR and check at-all. Drill-provider has dependency to `sqlalchemy-drill>=1.1.0,!=1.1.6,!=1.1.7` defined and this indirectly has the requirement of sqlalchemy. So irrespective of core dependency it is _alyways_ installing sqlalchemy, no conditional check needed in my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59916:
URL: https://github.com/apache/airflow/pull/59916#issuecomment-3699219651
> I am actually not sure whether we need this PR and check at-all. Drill-provider has dependency to sqlalchemy-drill>=1.1.0,!=1.1.6,!=1.1.7 defined and this indirectly has the requirement of sqlalchemy. So irrespective of core dependency it is alyways installing sqlalchemy, no conditional check needed in my view.
Agree. Looks like drill entirely depdens on sqlalchemy-drill -> it creates sqlalchemy engine in get_conn -> it does not use pure dbapi, just sqlalchemy to run queries.
We can close it and mark as done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #59916: Fix: Make sqlalchemy optional in Drill provider
URL: https://github.com/apache/airflow/pull/59916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #59916:
URL: https://github.com/apache/airflow/pull/59916#issuecomment-3697853486
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Make sqlalchemy optional in Drill provider [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on code in PR #59916:
URL: https://github.com/apache/airflow/pull/59916#discussion_r2652349998
##########
providers/apache/drill/src/airflow/providers/apache/drill/hooks/drill.py:
##########
@@ -52,6 +55,11 @@ class DrillHook(DbApiHook):
def get_conn(self) -> PoolProxiedConnection:
"""Establish a connection to Drillbit."""
conn_md = self.get_connection(self.get_conn_id())
+
+ if create_engine is None:
+
+ raise AirflowOptionalProviderFeatureException("The 'sqlalchemy' library is required to use this hook.")
Review Comment:
```suggestion
raise AirflowOptionalProviderFeatureException(
"sqlalchemy is required for SQL filter clause generation. "
"Install it with: pip install 'apache-airflow-providers-drill[sqlalchemy]'"
)
```
##########
providers/apache/drill/src/airflow/providers/apache/drill/hooks/drill.py:
##########
@@ -52,6 +55,11 @@ class DrillHook(DbApiHook):
def get_conn(self) -> PoolProxiedConnection:
"""Establish a connection to Drillbit."""
conn_md = self.get_connection(self.get_conn_id())
+
+ if create_engine is None:
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org