You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Stephane Nicoll (JIRA)" <ji...@codehaus.org> on 2005/07/12 14:32:57 UTC
[jira] Created: (MNG-576) Support of EAR lifecycle
Support of EAR lifecycle
------------------------
Key: MNG-576
URL: http://jira.codehaus.org/browse/MNG-576
Project: Maven 2
Type: Improvement
Components: maven-plugins, maven-core
Versions: 2.0-alpha-3
Reporter: Stephane Nicoll
Priority: Minor
Fix For: 2.0-beta-1
Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
First patch is to be applied on maven-core to register ear lifecycle
Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-576) Support of EAR lifecycle
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=all ]
John Casey updated MNG-576:
---------------------------
Priority: Blocker (was: Minor)
Escalating the priority on this, since patching maven-core isn't appropriate for new packaging handlers. The object of the game is to allow new type/package handlers to be added on the fly without modifying maven-core. However, unless I'm mistaken, these new lifecycle mappings will not be available simply by adding the type-handler plugin to the mix.
This will require some design time, so I'm going to make it a high priority.
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins, maven-core
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-576) Support of EAR lifecycle
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=all ]
John Casey closed MNG-576:
--------------------------
Resolution: Fixed
EAR lifecycle is working in the same manner as EJB and WAR now...and it has an integration test - it0033.
If we need to adjust the way plugins specify lifecycle mappings, we can continue to address that in MNG-598
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-core, maven-plugins
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-core-it-ear.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-576) Support of EAR lifecycle
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=comments#action_42976 ]
Brett Porter commented on MNG-576:
----------------------------------
hmmm, John - does this then solve MNG-598? I had thought of an alternate solution, didn't realise that you had already worked on it.
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-core, maven-plugins
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-core-it-ear.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-576) Support of EAR lifecycle
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=comments#action_42825 ]
Stephane Nicoll commented on MNG-576:
-------------------------------------
Okay. You'll have that this week end.
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins, maven-core
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-576) Support of EAR lifecycle
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=comments#action_42803 ]
John Casey commented on MNG-576:
--------------------------------
Applied the patches.
Stephane, I'm waiting for an integration test for the EAR plugin before I resolve this issue; can you provide one? just name it it00XX where XX is the next in the series under maven-core-it.
Thanks.
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins, maven-core
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-576) Support of EAR lifecycle
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=comments#action_42774 ]
John Casey commented on MNG-576:
--------------------------------
rough outline of my intended fix:
Requirements
------------------------
* plugins should provide new lifecycle mappings
Steps to Implement
------------------------
* add 1:N plugin:packaging mapping to maven-plugin-mapping model
* add support to maven-plugin-plugin to detect and add new packaging mappings to the plugins.xml mapping metadata
* add mapping of packaging->plugin to PluginMappingManager in maven-plugin-mapping
* add method getPluginComponent( Plugin, String role, String roleHint ) to PluginManager to enable LifecycleMapping lookup in the child container for the plugin
* rewire DefaultLifecycleExecutor to use the plugin manager and plugin mappings to find the lifecycle handler for a packaging
Plan of attack
-------------------------
1. Add <packagings/> to maven-plugin-mapping model
2. Add packaging->plugin mapping support to PluginMappingManager
3. Add LifecycleMapping detector to maven-plugin-plugin's GenerateUpdatedMappingMojo
4. Add PluginManager.getPluginComponent( Plugin, String, String ): Object
5. Change the code in DefaultLifecycleManager to utilize PluginMappingManager and PluginManager.getPluginComponent(..) rather than simply MavenSession.lookup( LifecycleMapping.ROLE, ..)
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins, maven-core
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-576) Support of EAR lifecycle
Posted by "J. Matthew Pryor (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=comments#action_42739 ]
J. Matthew Pryor commented on MNG-576:
--------------------------------------
I am pretty sure this is the same basic problem that has frustrated my attempts to write an M2 plugin to support Eclipse PDE artifacts. The only way I can register a plugin to handle a new packaging type is to modify maven-core/src/main/resources/META-INF/plexus/components.xml. Clearly this is not at all what plugin developers would want to do
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins, maven-core
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-576) Support of EAR lifecycle
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-576?page=all ]
Stephane Nicoll updated MNG-576:
--------------------------------
Attachment: maven-core-it-ear.patch
This patch adds an integration test for ear packaging. It is named it00xx, could you please replace by a valid number?
The test generates an EAR archive with an auto-generated application.xml as well as a custom application server deployment descriptor.
> Support of EAR lifecycle
> ------------------------
>
> Key: MNG-576
> URL: http://jira.codehaus.org/browse/MNG-576
> Project: Maven 2
> Type: Improvement
> Components: maven-core, maven-plugins
> Versions: 2.0-alpha-3
> Reporter: Stephane Nicoll
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: maven-core-ear-lifecycle.patch, maven-core-it-ear.patch, maven-ear-lifecycle.patch
>
>
> The following patches integrates the ear plugin into a m2 lifecycle so that m2 package / install / deploy / etc goals could be used with an 'ear' packaging.
> First patch is to be applied on maven-core to register ear lifecycle
> Second patch is to be applied on maven-plugins/maven-ear-plugin to add support of generateApplicationXml flag which states whether application.xml should be generated or not (default is true).
> This relates to MNG-563 where the original discussion took place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org