You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/26 06:11:06 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8658: fix: handle duplicate groupby keys

codecov-io commented on issue #8658: fix: handle duplicate groupby keys
URL: https://github.com/apache/incubator-superset/pull/8658#issuecomment-558476810
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=h1) Report
   > Merging [#8658](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/acf0753504095a5c0e320b049370aaf6f04e5a4f?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8658/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8658      +/-   ##
   ==========================================
   + Coverage   65.76%   65.76%   +<.01%     
   ==========================================
     Files         482      482              
     Lines       23824    23825       +1     
     Branches     2594     2594              
   ==========================================
   + Hits        15667    15668       +1     
     Misses       7984     7984              
     Partials      173      173
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.83% <100%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=footer). Last update [acf0753...88b2eaa](https://codecov.io/gh/apache/incubator-superset/pull/8658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org