You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "greggailly (via GitHub)" <gi...@apache.org> on 2026/08/31 06:21:26 UTC
Re: [PR] feat(folders): drag and drop visible elements (columns/metrics) of folders in explore view [superset]
greggailly commented on code in PR #42483:
URL: https://github.com/apache/superset/pull/42483#discussion_r3892152641
##########
superset-frontend/src/explore/components/DatasourcePanel/folderDrag.ts:
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { ColumnMeta, Metric } from '@superset-ui/chart-controls';
+import { FoldersEditorItemType } from 'src/components/Datasource/types';
+import { DndItemType } from '../DndItemType';
+import { DatasourcePanelDndItem, Folder, FolderItem } from './types';
+
+/**
+ * Map a single folder entry to the drag-item shape used by the control drop
+ * targets. Metrics become `DndItemType.Metric`, everything else a column.
+ */
+function toDndItem(item: FolderItem): DatasourcePanelDndItem {
+ return {
+ type:
+ item.type === FoldersEditorItemType.Metric
+ ? DndItemType.Metric
+ : DndItemType.Column,
+ // The runtime object carries the full ColumnMeta/Metric (see
+ // transformDatasourceWithFolders spreading `...column`/`...metric`), which
+ // is what the drop handlers expect.
+ value: item as ColumnMeta | Metric,
+ };
+}
+
+/**
+ * Flatten a folder into the list of draggable columns/metrics it contains,
+ * descending into subfolders so dragging a parent folder brings everything
+ * nested under it.
+ */
+export function collectFolderDragItems(
+ folder: Folder,
+): DatasourcePanelDndItem[] {
+ const items = folder.items.map(toDndItem);
Review Comment:
Changed the description to match the current behaviour which I believe is less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org