You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/05 20:26:24 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #19877: fix: Message toast charts update [42258]

rusackas commented on code in PR #19877:
URL: https://github.com/apache/superset/pull/19877#discussion_r866287058


##########
superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx:
##########
@@ -158,7 +158,7 @@ class HeaderActionsDropdown extends React.PureComponent {
     switch (key) {
       case MENU_KEYS.REFRESH_DASHBOARD:
         this.props.forceRefreshAllCharts();
-        this.props.addSuccessToast(t('Data refreshed'));
+        this.props.addSuccessToast(t('Refreshing Charts'));

Review Comment:
   ```suggestion
           this.props.addSuccessToast(t('Refreshing charts'));
   ```
   We keep things sentence case unless the noun is referring to the page, e.g. the Charts page.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org