You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/08 20:35:06 UTC
[GitHub] [flink] vahmed-hamdy opened a new pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
vahmed-hamdy opened a new pull request #18669:
URL: https://github.com/apache/flink/pull/18669
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
- Adding buffered requests in snapshot state of `AsyncSinkWriter` and its implementation so that the writers can resume the buffered requests when initiating from a snapshot.
## Brief change log
- Added `BufferedRequestsState` in `flink-connector-base`.
- Added `AsyncSinkWriterStateSerializer` in `flink-connector-base`.
- implemented `AsyncSinkWriterStateSerializer` in both `flink-connector-aws-kinesis-data-streams` and `flink-connector-aws-kinesis-firehose`.
-
## Verifying this change
- Added unit tests for new serializer class.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] CrynetLogistics commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
CrynetLogistics commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804519162
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
Review comment:
Interesting... noted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802815599
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
+ this.bufferedRequestEntries.addAll(state.getBufferedRequestEntries());
+
+ long sum = 0L;
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferedRequestEntries) {
+ if (wrapper.getSize() > maxRecordSizeInBytes) {
+ throw new IllegalStateException(
Review comment:
We allowed `maxBufferedRequests` to flush at the end of initialisation.
It is agreed not to validate and to drop the flush logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
}, {
"hash" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247",
"triggerID" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c53ab9b2ee239bd9df6b5de6a50356cf4be7911e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241)
* aadf56247b23684b230c6aa52ff008093f1cae8d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
}, {
"hash" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247",
"triggerID" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aadf56247b23684b230c6aa52ff008093f1cae8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804518817
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
Review comment:
it voilated `PUBLIC_EVOLVING_API_METHODS_USE_ONLY_PUBLIC_EVOLVING_API_TYPES` arch rule
the `snapshot()` function in the writer is publich and can't return an `@Internal` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 1354a81b74c87d62d962f07b066b6766eeda8191 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802818889
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
Review comment:
It was intended for readability, we would other wise be transfering state as `Collection<RequestEntryWrapper<RequestEntryT>>>` , I am fine removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
* c09bd68f357ba6dc0243892a4cbde5b0e4da05fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] CrynetLogistics commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
CrynetLogistics commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033673731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
* c09bd68f357ba6dc0243892a4cbde5b0e4da05fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974)
* b33d774d6f9739ada14ba3f8c007684898f4c3fc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #18669:
URL: https://github.com/apache/flink/pull/18669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r803465710
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import javax.annotation.Nullable;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ serializeExplicitHashKeyToStream(request.explicitHashKey(), out);
Review comment:
Agree, It is specific to serialize `BufferRequestsState` whose request would never have an explicit hash key.
will remove and assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033392547
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] CrynetLogistics commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
CrynetLogistics commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033843340
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033137354
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802781372
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
Review comment:
Why is this `@PublicEvolving`?
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final Long stateSize;
+
+ public BufferedRequestState(
+ Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = bufferedRequestEntries;
Review comment:
Would be better to copy the collection contents here. We care about order so might aswell upgrade to `List`
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final Long stateSize;
Review comment:
This can be `long`
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
+ this.bufferedRequestEntries.addAll(state.getBufferedRequestEntries());
+
+ long sum = 0L;
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferedRequestEntries) {
+ if (wrapper.getSize() > maxRecordSizeInBytes) {
+ throw new IllegalStateException(
+ String.format(
+ "State contains record of size %d which exceeds sink maximum record size %d.",
+ wrapper.getSize(), maxRecordSizeInBytes));
+ }
+
+ sum = sum + wrapper.getSize();
Review comment:
nit: `sum += wrapper.getSize();`
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/RequestEntryWrapper.java
##########
@@ -45,4 +47,25 @@ public RequestEntryT getRequestEntry() {
public long getSize() {
return size;
}
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == this) {
+ return true;
+ }
+
+ if (other == null || other.getClass() != this.getClass()) {
+ return false;
+ }
+
+ RequestEntryWrapper<RequestEntryT> that = (RequestEntryWrapper<RequestEntryT>) other;
+
+ return Objects.equals(this.size, that.size)
+ && Objects.equals(this.requestEntry, that.requestEntry);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(size, requestEntry);
+ }
Review comment:
Same question as above, why add this?
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final Long stateSize;
+
+ public BufferedRequestState(
+ Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = bufferedRequestEntries;
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public Collection<RequestEntryWrapper<RequestEntryT>> getBufferedRequestEntries() {
+ return bufferedRequestEntries;
+ }
+
+ public Long getStateSize() {
Review comment:
This is not used
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final Long stateSize;
+
+ public BufferedRequestState(
+ Collection<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = bufferedRequestEntries;
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public Collection<RequestEntryWrapper<RequestEntryT>> getBufferedRequestEntries() {
+ return bufferedRequestEntries;
+ }
+
+ public Long getStateSize() {
+ return stateSize;
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == this) {
+ return true;
+ }
+
+ if (other == null || other.getClass() != this.getClass()) {
+ return false;
+ }
+ BufferedRequestState<RequestEntryT> that = (BufferedRequestState<RequestEntryT>) other;
+ return Arrays.equals(
+ this.bufferedRequestEntries.toArray(), that.bufferedRequestEntries.toArray());
+ }
+
+ @Override
+ public int hashCode() {
+ int hash = 0;
+ for (RequestEntryWrapper<RequestEntryT> request : bufferedRequestEntries) {
+ hash = Objects.hash(hash, request);
+ }
+
+ return hash;
+ }
Review comment:
Why did you implement this? Flink coding standard advise against this unless really necessary https://flink.apache.org/contributing/code-style-and-quality-java.html
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
Review comment:
Please improve this comment
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterStateSerializer.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Serializer class for {@link AsyncSinkWriter} state.
+ *
+ * @param <RequestEntryT> Writer Request Entry type
+ */
+@Internal
+public abstract class AsyncSinkWriterStateSerializer<RequestEntryT extends Serializable>
+ implements SimpleVersionedSerializer<BufferedRequestState<RequestEntryT>> {
+ private static final long DATA_IDENTIFIER = -1;
+
+ // Serializes state in form of
+ // [DATA_IDENTIFIER,NUM_OF_ELEMENTS,SIZE1,REQUEST1,SIZE2,REQUEST2....]
Review comment:
Use a multiline javadoc here instead of multiple single line comments
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
Review comment:
What is the point in this class? It is simply wrapping a `List`, why not just use List?
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
+ this.bufferedRequestEntries.addAll(state.getBufferedRequestEntries());
+
+ long sum = 0L;
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferedRequestEntries) {
+ if (wrapper.getSize() > maxRecordSizeInBytes) {
+ throw new IllegalStateException(
+ String.format(
+ "State contains record of size %d which exceeds sink maximum record size %d.",
+ wrapper.getSize(), maxRecordSizeInBytes));
+ }
+
+ sum = sum + wrapper.getSize();
Review comment:
Can you use `state.getStateSize()` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033041272
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 22921c50a0e5c785368301c1008d1067a56a3560 (Tue Feb 08 20:40:21 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804485922
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializerTest.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.api.common.serialization.SimpleStringSchema;
+import org.apache.flink.connector.base.sink.writer.BufferedRequestState;
+import org.apache.flink.connector.base.sink.writer.ElementConverter;
+import org.apache.flink.connector.base.sink.writer.RequestEntryWrapper;
+
+import org.junit.Test;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.IOException;
+import java.util.List;
+
+import static org.apache.flink.connector.base.sink.writer.AsyncSinkWriterTestUtils.getTestState;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/** Test class for {@link KinesisDataStreamsStateSerializer}. */
+public class KinesisDataStreamsStateSerializerTest {
+
+ private static final ElementConverter<String, PutRecordsRequestEntry> ELEMENT_CONVERTER =
+ KinesisDataStreamsSinkElementConverter.<String>builder()
+ .setSerializationSchema(new SimpleStringSchema())
+ .setPartitionKeyGenerator(element -> String.valueOf(element.hashCode()))
+ .build();
+
+ @Test
+ public void testSerializeAndDeserialize() throws IOException {
+ BufferedRequestState<PutRecordsRequestEntry> expectedState =
+ getTestState(ELEMENT_CONVERTER, this::getRequestSize);
+
+ KinesisDataStreamsStateSerializer serializer = new KinesisDataStreamsStateSerializer();
+ BufferedRequestState<PutRecordsRequestEntry> actualState =
+ serializer.deserialize(1, serializer.serialize(expectedState));
+ assertThatBufferStatesAreEqual(actualState, expectedState);
+ }
+
+ private int getRequestSize(PutRecordsRequestEntry requestEntry) {
+ return requestEntry.data().asByteArrayUnsafe().length;
+ }
+
+ private static void assertThatBufferStatesAreEqual(
+ BufferedRequestState<PutRecordsRequestEntry> actual,
+ BufferedRequestState<PutRecordsRequestEntry> expected) {
+ assertEquals(actual.getStateSize(), expected.getStateSize());
+ int actualLength = actual.getBufferedRequestEntries().size();
+ assertEquals(actualLength, expected.getBufferedRequestEntries().size());
+ List<RequestEntryWrapper<PutRecordsRequestEntry>> actualRequests =
+ actual.getBufferedRequestEntries();
+ List<RequestEntryWrapper<PutRecordsRequestEntry>> expectedRequests =
+ expected.getBufferedRequestEntries();
+ for (int i = 0; i < actualLength; i++) {
+ assertEquals(
+ actualRequests.get(i).getRequestEntry(),
+ expectedRequests.get(i).getRequestEntry());
+ assertEquals(actualRequests.get(i).getSize(), expectedRequests.get(i).getSize());
+ }
Review comment:
nit: Add new lines to make this more readable
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes(StandardCharsets.UTF_8));
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ String.format(
+ "KinesisDataStreamsStateSerializer is incompatible with ElementConverter."
+ + "Serializer version %d does not support explicit hash key.",
+ getVersion()));
+ }
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = new byte[(int) requestSize];
+ in.read(requestData);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyFromStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyFromStream(DataInputStream in) throws IOException {
+ int partitionKeyLength = in.readInt();
+ byte[] requestPartitionKeyData = new byte[(int) partitionKeyLength];
+ in.read(requestPartitionKeyData);
Review comment:
We need to confirm that this will always read the entire length of the string.
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterStateSerializer.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Serializer class for {@link AsyncSinkWriter} state.
+ *
+ * @param <RequestEntryT> Writer Request Entry type
+ */
+@Internal
+public abstract class AsyncSinkWriterStateSerializer<RequestEntryT extends Serializable>
+ implements SimpleVersionedSerializer<BufferedRequestState<RequestEntryT>> {
+ private static final long DATA_IDENTIFIER = -1;
+
+ /**
+ * Serializes state in form of
+ * [DATA_IDENTIFIER,NUM_OF_ELEMENTS,SIZE1,REQUEST1,SIZE2,REQUEST2....].
+ */
+ @Override
+ public byte[] serialize(BufferedRequestState<RequestEntryT> obj) throws IOException {
+ Collection<RequestEntryWrapper<RequestEntryT>> bufferState =
+ obj.getBufferedRequestEntries();
+ try (final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ final DataOutputStream out = new DataOutputStream(baos)) {
+ out.writeLong(DATA_IDENTIFIER);
+ out.writeInt(bufferState.size());
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferState) {
+ out.writeLong(wrapper.getSize());
+ serializeRequestToStream(wrapper.getRequestEntry(), out);
+ }
+ return baos.toByteArray();
+ }
+ }
+
+ @Override
+ public BufferedRequestState<RequestEntryT> deserialize(int version, byte[] serialized)
+ throws IOException {
+ try (final ByteArrayInputStream bais = new ByteArrayInputStream(serialized);
+ final DataInputStream in = new DataInputStream(bais)) {
+ validateIdentifier(in);
+ int size = in.readInt();
+ List<RequestEntryWrapper<RequestEntryT>> serializedState = new ArrayList<>();
+ for (int i = 0; i < size; i++) {
+ long requestSize = in.readLong();
+ RequestEntryT request = deserializeRequestFromStream(requestSize, in);
+ serializedState.add(new RequestEntryWrapper<>(request, requestSize));
+ }
+
+ return new BufferedRequestState<>(serializedState);
+ }
+ }
Review comment:
nit: Add new lines to make more readable
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
Review comment:
Why is this failing?
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTestUtils.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import java.io.Serializable;
+import java.util.List;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/** Utils class for {@link AsyncSinkWriter} related test. */
+public class AsyncSinkWriterTestUtils {
+
+ public static <T extends Serializable> BufferedRequestState<T> getTestState(
+ ElementConverter<String, T> elementConverter,
+ Function<T, Integer> requestSizeExtractor) {
+ return new BufferedRequestState<>(
+ IntStream.range(0, 100)
+ .mapToObj(i -> String.format("value:%d", i))
+ .map(element -> elementConverter.apply(element, null))
+ .map(
+ request ->
+ new RequestEntryWrapper<>(
+ request, requestSizeExtractor.apply(request)))
+ .collect(Collectors.toList()));
+ }
+
+ public static <T extends Serializable> void assertThatBufferStatesAreEqual(
+ BufferedRequestState<T> actual, BufferedRequestState<T> expected) {
+ assertEquals(actual.getStateSize(), expected.getStateSize());
+ int actualLength = actual.getBufferedRequestEntries().size();
+ assertEquals(actualLength, expected.getBufferedRequestEntries().size());
+ List<RequestEntryWrapper<T>> actualRequests = actual.getBufferedRequestEntries();
+ List<RequestEntryWrapper<T>> expectedRequests = expected.getBufferedRequestEntries();
+ for (int i = 0; i < actualLength; i++) {
+ assertEquals(
+ actualRequests.get(i).getRequestEntry(),
+ expectedRequests.get(i).getRequestEntry());
+ assertEquals(actualRequests.get(i).getSize(), expectedRequests.get(i).getSize());
+ }
+ }
Review comment:
nit: add whitespace to make this more readable
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
Review comment:
nit:
```
this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
```
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
Review comment:
Please see guidance on use of java streams. Unfortunately I would consider this performance critical and therefore please remove streams: https://flink.apache.org/contributing/code-style-and-quality-java.html#java-streams
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes(StandardCharsets.UTF_8));
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ String.format(
+ "KinesisDataStreamsStateSerializer is incompatible with ElementConverter."
+ + "Serializer version %d does not support explicit hash key.",
+ getVersion()));
+ }
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = new byte[(int) requestSize];
+ in.read(requestData);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyFromStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyFromStream(DataInputStream in) throws IOException {
+ int partitionKeyLength = in.readInt();
+ byte[] requestPartitionKeyData = new byte[(int) partitionKeyLength];
+ in.read(requestPartitionKeyData);
Review comment:
I see this is a wrapped byte array in the parent class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804518817
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
Review comment:
it voilated `PUBLIC_EVOLVING_API_METHODS_USE_ONLY_PUBLIC_EVOLVING_API_TYPES` arch rule
the `snapshot()` function in the writer is public and can't return an `@Internal` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804660040
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ this.stateSize = calculateStateSize();
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ this.stateSize = calculateStateSize();
+ }
Review comment:
They were already, were split out to ensure an ordering data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
}, {
"hash" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247",
"triggerID" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
* c53ab9b2ee239bd9df6b5de6a50356cf4be7911e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241)
* aadf56247b23684b230c6aa52ff008093f1cae8d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31247)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r803555992
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterStateSerializer.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Serializer class for {@link AsyncSinkWriter} state.
+ *
+ * @param <RequestEntryT> Writer Request Entry type
+ */
+@Internal
+public abstract class AsyncSinkWriterStateSerializer<RequestEntryT extends Serializable>
+ implements SimpleVersionedSerializer<BufferedRequestState<RequestEntryT>> {
+ private static final long DATA_IDENTIFIER = -1;
+
+ /**
+ * Serializes state in form of
+ * [DATA_IDENTIFIER,NUM_OF_ELEMENTS,SIZE1,REQUEST1,SIZE2,REQUEST2....].
+ */
+ @Override
+ public byte[] serialize(BufferedRequestState<RequestEntryT> obj) throws IOException {
+ Collection<RequestEntryWrapper<RequestEntryT>> bufferState =
+ obj.getBufferedRequestEntries();
+ try (final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ final DataOutputStream out = new DataOutputStream(baos)) {
+ out.writeLong(DATA_IDENTIFIER);
+ out.writeInt(bufferState.size());
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferState) {
+ out.writeLong(wrapper.getSize());
+ serializeRequestToStream(wrapper.getRequestEntry(), out);
+ }
+ return baos.toByteArray();
+ }
+ }
+
+ @Override
+ public BufferedRequestState<RequestEntryT> deserialize(int version, byte[] serialized)
+ throws IOException {
+ try (final ByteArrayInputStream bais = new ByteArrayInputStream(serialized);
+ final DataInputStream in = new DataInputStream(bais)) {
+ validateIdentifier(in);
+ int size = readInt(in);
+ List<RequestEntryWrapper<RequestEntryT>> serializedState = new ArrayList<>();
+ for (int i = 0; i < size; i++) {
+ long requestSize = readLong(in);
+ RequestEntryT request = deserializeRequestFromStream(requestSize, in);
+ serializedState.add(new RequestEntryWrapper<>(request, requestSize));
+ }
+
+ return new BufferedRequestState<>(serializedState);
+ }
+ }
+
+ protected abstract void serializeRequestToStream(RequestEntryT request, DataOutputStream out)
+ throws IOException;
+
+ protected abstract RequestEntryT deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException;
+
+ private void validateIdentifier(DataInputStream in) throws IOException {
+ if (readLong(in) != DATA_IDENTIFIER) {
+ throw new IllegalStateException("Corrupted data to deserialize");
+ }
+ }
+
+ protected Long readLong(DataInputStream in) throws IOException {
+ try {
+ return in.readLong();
+ } catch (IndexOutOfBoundsException | EOFException e) {
+ throw new IllegalStateException("Incomplete serialized state");
Review comment:
If we are going to rethrow we should wrap `e`. However, I would be inclined to just remove these methods `readLong`/`readInt` directly and let the exceptions bubble up. This is similar to other implementations. Generally speaking it is bad practise to catch `RuntimeException`
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ "Request contains field not included in serialization.");
+ }
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = readBytes(in, (int) requestSize);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyToStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyToStream(DataInputStream in) throws IOException {
Review comment:
> deserializePartitionKeyToStream
`deserializePartitionKeyFromStream` ?
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterStateSerializerTest.java
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.assertj.core.api.Assertions;
+import org.junit.Test;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/** Test class for {@link AsyncSinkWriterStateSerializer}. */
+public class AsyncSinkWriterStateSerializerTest {
+
+ @Test
+ public void testSerializeAndDeSerialize() throws IOException {
+ AsyncSinkWriterStateSerializerImpl stateSerializer =
+ new AsyncSinkWriterStateSerializerImpl();
+ List<String> testData = getTestData(100);
+ BufferedRequestState<String> state = wrapStringRequests(testData);
+ Collection<String> deserializedState =
+ stripStringEntryWrappers(
+ stateSerializer.deserialize(0, stateSerializer.serialize(state)));
+
+ Assertions.assertThat(deserializedState).isEqualTo(testData);
+ }
+
+ private List<String> getTestData(int size) {
+ List<String> testData = new ArrayList<>();
+ for (int i = 1; i <= size; i++) {
+ testData.add(String.format("value:%d", i));
+ }
+ return testData;
+ }
Review comment:
This is duplicated in a few places. Can we move to a test util? Also can simplify with java streams as pointed out in a nit comment above
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +426,28 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(new BufferedRequestState<>((bufferedRequestEntries)));
+ }
+
+ protected void initialize(List<BufferedRequestState<RequestEntryT>> states) {
+ if (states.isEmpty()) {
+ return;
+ }
+
+ BufferedRequestState<RequestEntryT> state = states.get(0);
Review comment:
Can we validate that there are no more than 1? Do we already do this somewhere?
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>();
+ this.bufferedRequestEntries.addAll(bufferedRequestEntries);
+ this.stateSize =
+ bufferedRequestEntries.stream()
+ .map(RequestEntryWrapper::getSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ public List<RequestEntryWrapper<RequestEntryT>> getBufferedRequestEntries() {
+ return bufferedRequestEntries;
+ }
+
+ public Long getStateSize() {
Review comment:
This should be `long` not `Long`
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializerTest.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.api.common.serialization.SimpleStringSchema;
+import org.apache.flink.connector.base.sink.writer.BufferedRequestState;
+import org.apache.flink.connector.base.sink.writer.ElementConverter;
+import org.apache.flink.connector.base.sink.writer.RequestEntryWrapper;
+
+import org.junit.Test;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/** Test class for {@link KinesisDataStreamsStateSerializer}. */
+public class KinesisDataStreamsStateSerializerTest {
+
+ private static final ElementConverter<String, PutRecordsRequestEntry> ELEMENT_CONVERTER =
+ KinesisDataStreamsSinkElementConverter.<String>builder()
+ .setSerializationSchema(new SimpleStringSchema())
+ .setPartitionKeyGenerator(element -> String.valueOf(element.hashCode()))
+ .build();
+
+ @Test
+ public void testSerializeAndDeserialize() throws IOException {
+ BufferedRequestState<PutRecordsRequestEntry> expectedState = getTestState();
+
+ KinesisDataStreamsStateSerializer serializer = new KinesisDataStreamsStateSerializer();
+ BufferedRequestState<PutRecordsRequestEntry> actualState =
+ serializer.deserialize(1, serializer.serialize(expectedState));
+ assertThatBufferStatesAreEqual(actualState, expectedState);
+ }
+
+ private BufferedRequestState<PutRecordsRequestEntry> getTestState() {
+ List<String> testData = getTestData(100);
Review comment:
nit:
```
return new BufferedRequestState<PutRecordsRequestEntry>(IntStream.range(0, 100)
.mapToObj(i -> String.format("value:%d", i))
.map(element -> ELEMENT_CONVERTER.apply(element, null))
.map(request -> new RequestEntryWrapper<>(request, getRequestSize(request)))
.collect(Collectors.toList()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r803575849
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ "Request contains field not included in serialization.");
+ }
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = readBytes(in, (int) requestSize);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyToStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyToStream(DataInputStream in) throws IOException {
+ int partitionKeyLength = readInt(in);
+ byte[] requestPartitionKeyData = readBytes(in, partitionKeyLength);
+ return new String(requestPartitionKeyData);
+ }
Review comment:
It is agreed to remove byte stream validation and bubble up the original error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] CrynetLogistics commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
CrynetLogistics commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033842115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802808380
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * Class holding internal state of buffered requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
Review comment:
I wanted to use `@Internal` but this fails architecture tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802570306
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java
##########
@@ -126,13 +126,19 @@
getMaxRecordSizeInBytes(),
failOnError,
streamName,
- kinesisClientProperties);
+ kinesisClientProperties,
+ getInitialState(states));
+ }
+
+ private BufferedRequestState<PutRecordsRequestEntry> getInitialState(
+ List<BufferedRequestState<PutRecordsRequestEntry>> states) {
+ return states.isEmpty() ? BufferedRequestState.emptyState() : states.get(0);
Review comment:
Why are we discarding the other items in the list here? Are we expecting the list to be size 1? If so, can we validate that and fail if not the case?
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public final class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = new byte[(int) requestSize];
+ in.read(requestData);
+ return PutRecordsRequestEntry.builder().data(SdkBytes.fromByteArray(requestData)).build();
+ }
+
+ @Override
+ public int getVersion() {
+ return 0;
Review comment:
We should set this to 1, as 0 is equivalent to unset
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public final class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = new byte[(int) requestSize];
+ in.read(requestData);
+ return PutRecordsRequestEntry.builder().data(SdkBytes.fromByteArray(requestData)).build();
Review comment:
We are not setting the partition key here. Also, this implementation seems like it needs to be tied to the `ElementConverter`, somehow
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
Review comment:
Do we not expect this to be clear already? We should add validation to assert this. But based on my other feedback, if this method should only be called during construction we should make it private
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
+ this.bufferedRequestEntries.addAll(state.getBufferedRequestEntries());
+
+ long sum = 0L;
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferedRequestEntries) {
+ if (wrapper.getSize() > maxRecordSizeInBytes) {
+ throw new IllegalStateException(
Review comment:
How about other validations such as number of buffered records (`maxBufferedRequests`)? Maybe we should allow this condition
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkWriter.java
##########
@@ -97,6 +126,7 @@
this.metrics = context.metricGroup();
this.numRecordsOutErrorsCounter = metrics.getNumRecordsOutErrorsCounter();
this.client = buildClient(kinesisClientProperties);
+ initialize(state);
Review comment:
Can this go in the super class? Seems better to pass the `state` to `AsyncSinkWriter` and let it handle the init?
##########
File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSink.java
##########
@@ -105,11 +105,18 @@
getMaxRecordSizeInBytes(),
failOnError,
deliveryStreamName,
- firehoseClientProperties);
+ firehoseClientProperties,
+ getInitialState(states));
+ }
+
+ private BufferedRequestState<Record> getInitialState(
+ List<BufferedRequestState<Record>> states) {
+ return states.isEmpty() ? BufferedRequestState.emptyState() : states.get(0);
Review comment:
Same question as KDS
##########
File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseStateSerializer.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.firehose.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.firehose.model.Record;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Firehose implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisFirehoseStateSerializer extends AsyncSinkWriterStateSerializer<Record> {
+ @Override
+ protected void serializeRequestToStream(Record request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ }
+
+ @Override
+ protected Record deserializeRequestFromStream(long requestSize, DataInputStream in)
+ throws IOException {
+ byte[] requestData = new byte[(int) requestSize];
+ in.read(requestData);
+ return Record.builder().data(SdkBytes.fromByteArray(requestData)).build();
+ }
+
+ @Override
+ public int getVersion() {
+ return 0;
Review comment:
We should set this to 1, as 0 is equivalent to unset
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public final class KinesisDataStreamsStateSerializer
Review comment:
I cannot see any unit tests to cover the SerDe
##########
File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseStateSerializer.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.firehose.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.firehose.model.Record;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Firehose implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisFirehoseStateSerializer extends AsyncSinkWriterStateSerializer<Record> {
Review comment:
I cannot see any unit tests to cover the SerDe
##########
File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriter.java
##########
@@ -118,6 +147,7 @@ private static FirehoseAsyncClient createFirehoseClient(
this.numRecordsOutErrorsCounter = metrics.getNumRecordsOutErrorsCounter();
this.httpClient = createHttpClient(firehoseClientProperties);
this.firehoseClient = createFirehoseClient(firehoseClientProperties, httpClient);
+ initialize(initialState);
Review comment:
Same as for KDS
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public final class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
Review comment:
Instead of just ripping out the data, can we serialise the whole object instead?
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -406,11 +403,30 @@ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
* a failure/restart of the application.
*/
@Override
- public List<Collection<RequestEntryT>> snapshotState() {
- return Arrays.asList(
- bufferedRequestEntries.stream()
- .map(RequestEntryWrapper::getRequestEntry)
- .collect(Collectors.toList()));
+ public List<BufferedRequestState<RequestEntryT>> snapshotState() {
+ return Collections.singletonList(
+ new BufferedRequestState<>(
+ Collections.unmodifiableCollection(bufferedRequestEntries)));
+ }
+
+ protected void initialize(BufferedRequestState<RequestEntryT> state) {
+ this.bufferedRequestEntries.clear();
+ this.bufferedRequestEntries.addAll(state.getBufferedRequestEntries());
+
+ long sum = 0L;
+ for (RequestEntryWrapper<RequestEntryT> wrapper : bufferedRequestEntries) {
+ if (wrapper.getSize() > maxRecordSizeInBytes) {
+ throw new IllegalStateException(
+ String.format(
+ "State contains record of size %d which exceeds sink maximum record size %d.",
+ wrapper.getSize(), maxRecordSizeInBytes));
+ }
+
+ sum = sum + wrapper.getSize();
+ }
+
+ this.bufferedRequestEntriesTotalSizeInBytes = sum;
+ flushIfAble();
Review comment:
Is this the right time to flush? Would this state restore be called during operator `initializing` state? If so, we probably do not want to flush here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r802792404
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java
##########
@@ -126,13 +126,19 @@
getMaxRecordSizeInBytes(),
failOnError,
streamName,
- kinesisClientProperties);
+ kinesisClientProperties,
+ getInitialState(states));
+ }
+
+ private BufferedRequestState<PutRecordsRequestEntry> getInitialState(
+ List<BufferedRequestState<PutRecordsRequestEntry>> states) {
+ return states.isEmpty() ? BufferedRequestState.emptyState() : states.get(0);
Review comment:
Yes, we wrap the entire state in a single item.
I agree, will validate and fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
* c53ab9b2ee239bd9df6b5de6a50356cf4be7911e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 1354a81b74c87d62d962f07b066b6766eeda8191 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033066159
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033081140
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b33d774d6f9739ada14ba3f8c007684898f4c3fc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c09bd68f357ba6dc0243892a4cbde5b0e4da05fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974)
* b33d774d6f9739ada14ba3f8c007684898f4c3fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] CrynetLogistics commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
CrynetLogistics commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033653020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1354a81b74c87d62d962f07b066b6766eeda8191 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028)
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c09bd68f357ba6dc0243892a4cbde5b0e4da05fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974)
* b33d774d6f9739ada14ba3f8c007684898f4c3fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b33d774d6f9739ada14ba3f8c007684898f4c3fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033648487
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b33d774d6f9739ada14ba3f8c007684898f4c3fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1354a81b74c87d62d962f07b066b6766eeda8191 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028)
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804576612
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ }
+
+ public List<RequestEntryWrapper<RequestEntryT>> getBufferedRequestEntries() {
+ return bufferedRequestEntries;
+ }
+
+ public long getStateSize() {
+ long stateSize = 0;
+ for (RequestEntryWrapper<RequestEntryT> requestEntryWrapper : bufferedRequestEntries) {
+ stateSize += requestEntryWrapper.getSize();
+ }
+
+ return stateSize;
+ }
Review comment:
For performance reasons I would prefer that this is computed in the constructor as before and stored as an instance variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951)
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1354a81b74c87d62d962f07b066b6766eeda8191 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r804656949
##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.sink.writer;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+
+/**
+ * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures
+ * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This
+ * guarantees at least once semantic in sending requests where restoring from a snapshot where
+ * buffered requests were flushed to the sink will cause duplicate requests.
+ *
+ * @param <RequestEntryT> request type.
+ */
+@PublicEvolving
+public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable {
+ private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries;
+ private final long stateSize;
+
+ public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ this.stateSize = calculateStateSize();
+ }
+
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) {
+ this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ this.stateSize = calculateStateSize();
+ }
Review comment:
Could be combined with `Collection` interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
* f7b2480909019bf786dcc9d58680be202458e2c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vahmed-hamdy commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
vahmed-hamdy commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033419382
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b33c5cff12c7a0523e4644a7fec0be0bf608f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059)
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* a6acf0d775c499f07cb088b71c0f6cdce68fd66c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
* c09bd68f357ba6dc0243892a4cbde5b0e4da05fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r803439459
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import javax.annotation.Nullable;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ serializeExplicitHashKeyToStream(request.explicitHashKey(), out);
Review comment:
We never set this in the `ElementConverter` right? Should we remove this from here and assert that it is null?
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import javax.annotation.Nullable;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ serializeExplicitHashKeyToStream(request.explicitHashKey(), out);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void serializeExplicitHashKeyToStream(
+ @Nullable String explicitHashKey, DataOutputStream out) throws IOException {
+ if (explicitHashKey == null) {
+ out.writeInt(0);
+ return;
+ }
+
+ out.writeInt(explicitHashKey.length());
+ out.write(explicitHashKey.getBytes());
+ }
Review comment:
These methods are duplicated/could be combined.
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import javax.annotation.Nullable;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ serializeExplicitHashKeyToStream(request.explicitHashKey(), out);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void serializeExplicitHashKeyToStream(
+ @Nullable String explicitHashKey, DataOutputStream out) throws IOException {
+ if (explicitHashKey == null) {
+ out.writeInt(0);
+ return;
+ }
+
+ out.writeInt(explicitHashKey.length());
+ out.write(explicitHashKey.getBytes());
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = readBytes(in, (int) requestSize);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyToStream(in))
+ .explicitHashKey(deserializeExplicitHashKeyToStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyToStream(DataInputStream in) throws IOException {
+ int partitionKeyLength = readInt(in);
+ byte[] requestPartitionKeyData = readBytes(in, partitionKeyLength);
+ return new String(requestPartitionKeyData);
+ }
+
+ protected String deserializeExplicitHashKeyToStream(DataInputStream in) throws IOException {
+ int explicitHashKeyLength = readInt(in);
+ if (explicitHashKeyLength == 0) {
+ return null;
+ }
+
+ byte[] explicitHashKeyData = readBytes(in, explicitHashKeyLength);
+ return new String(explicitHashKeyData);
+ }
Review comment:
These methods are duplicated/could be combined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18669:
URL: https://github.com/apache/flink/pull/18669#discussion_r803521963
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ "Request contains field not included in serialization.");
Review comment:
nit: I think we can be more specific here. Can we update to suggest that the `ElementConverter` has evolved without updating the state serialiser?
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
+ }
+
+ protected void validateExplicitHashKey(PutRecordsRequestEntry request) {
+ if (request.explicitHashKey() != null) {
+ throw new IllegalStateException(
+ "Request contains field not included in serialization.");
+ }
+ }
+
+ @Override
+ protected PutRecordsRequestEntry deserializeRequestFromStream(
+ long requestSize, DataInputStream in) throws IOException {
+ byte[] requestData = readBytes(in, (int) requestSize);
+
+ return PutRecordsRequestEntry.builder()
+ .data(SdkBytes.fromByteArray(requestData))
+ .partitionKey(deserializePartitionKeyToStream(in))
+ .build();
+ }
+
+ protected String deserializePartitionKeyToStream(DataInputStream in) throws IOException {
+ int partitionKeyLength = readInt(in);
+ byte[] requestPartitionKeyData = readBytes(in, partitionKeyLength);
+ return new String(requestPartitionKeyData);
+ }
Review comment:
Since we have helper methods in parent `readInt`/`readLong` we could make this `readString` ?
##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsStateSerializer.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.base.sink.writer.AsyncSinkWriterStateSerializer;
+
+import software.amazon.awssdk.core.SdkBytes;
+import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
+/** Kinesis Streams implementation {@link AsyncSinkWriterStateSerializer}. */
+@Internal
+public class KinesisDataStreamsStateSerializer
+ extends AsyncSinkWriterStateSerializer<PutRecordsRequestEntry> {
+ @Override
+ protected void serializeRequestToStream(PutRecordsRequestEntry request, DataOutputStream out)
+ throws IOException {
+ out.write(request.data().asByteArrayUnsafe());
+ serializePartitionKeyToStream(request.partitionKey(), out);
+ validateExplicitHashKey(request);
+ }
+
+ protected void serializePartitionKeyToStream(String partitionKey, DataOutputStream out)
+ throws IOException {
+ out.writeInt(partitionKey.length());
+ out.write(partitionKey.getBytes());
Review comment:
We should specify the charset so data is portable between systems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22921c50a0e5c785368301c1008d1067a56a3560 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948)
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a104bf0fe75823e4946852d66fb5ad117d585b6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104)
* b35192da26215222b167cdffbb9f45091fb4c559 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125)
* 0821dc818041b4be18d1327b9f5d5ca18deff594 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
}, {
"hash" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aadf56247b23684b230c6aa52ff008093f1cae8d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
* c53ab9b2ee239bd9df6b5de6a50356cf4be7911e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241)
* aadf56247b23684b230c6aa52ff008093f1cae8d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18669:
URL: https://github.com/apache/flink/pull/18669#issuecomment-1033040800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22921c50a0e5c785368301c1008d1067a56a3560",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30948",
"triggerID" : "22921c50a0e5c785368301c1008d1067a56a3560",
"triggerType" : "PUSH"
}, {
"hash" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30951",
"triggerID" : "a6acf0d775c499f07cb088b71c0f6cdce68fd66c",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"triggerType" : "PUSH"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033137354",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033066159",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033081140",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033392547",
"triggerType" : "MANUAL"
}, {
"hash" : "d025b76c02f35a4c6e56311a7dfed49b5d0dc9d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30953",
"triggerID" : "1033419382",
"triggerType" : "MANUAL"
}, {
"hash" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30974",
"triggerID" : "c09bd68f357ba6dc0243892a4cbde5b0e4da05fe",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"triggerType" : "PUSH"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653082",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673766",
"triggerType" : "MANUAL"
}, {
"hash" : "b33d774d6f9739ada14ba3f8c007684898f4c3fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31004",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033648487",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033653020",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033673731",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31028",
"triggerID" : "1354a81b74c87d62d962f07b066b6766eeda8191",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842115",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842205",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842264",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033842490",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1033843340",
"triggerType" : "MANUAL"
}, {
"hash" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31059",
"triggerID" : "17b33c5cff12c7a0523e4644a7fec0be0bf608f3",
"triggerType" : "PUSH"
}, {
"hash" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31104",
"triggerID" : "5a104bf0fe75823e4946852d66fb5ad117d585b6",
"triggerType" : "PUSH"
}, {
"hash" : "b35192da26215222b167cdffbb9f45091fb4c559",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31125",
"triggerID" : "b35192da26215222b167cdffbb9f45091fb4c559",
"triggerType" : "PUSH"
}, {
"hash" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31139",
"triggerID" : "0821dc818041b4be18d1327b9f5d5ca18deff594",
"triggerType" : "PUSH"
}, {
"hash" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154",
"triggerID" : "f7b2480909019bf786dcc9d58680be202458e2c4",
"triggerType" : "PUSH"
}, {
"hash" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241",
"triggerID" : "c53ab9b2ee239bd9df6b5de6a50356cf4be7911e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7b2480909019bf786dcc9d58680be202458e2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31154)
* c53ab9b2ee239bd9df6b5de6a50356cf4be7911e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org