You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/10/13 16:13:32 UTC

[GitHub] [incubator-heron] surahman commented on a change in pull request #3710: [HERON-3707] ConfigMap Pod Template Support

surahman commented on a change in pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#discussion_r728231089



##########
File path: deploy/kubernetes/general/apiserver.yaml
##########
@@ -95,6 +95,7 @@ spec:
               -D heron.uploader.dlog.topologies.namespace.uri=distributedlog://zookeeper:2181/heron
               -D heron.statefulstorage.classname=org.apache.heron.statefulstorage.dlog.DlogStorage
               -D heron.statefulstorage.dlog.namespace.uri=distributedlog://zookeeper:2181/heron
+            # -D heron.kubernetes.pod.template.configmap.disabled=true

Review comment:
       Hi @nwangtw, thank you for the review 😄.
   
   This is a pertinent question and an equally good point. I left it there so that people are aware that the feature can be disabled and to make it easy to switch it off without having to look anything up. I am indifferent about discarding it but feel it should be there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org