You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/12 18:33:03 UTC

[GitHub] [incubator-eventmesh] venu-prasanna opened a new pull request, #1552: [ISSUE #1526] update all map fetch value

venu-prasanna opened a new pull request, #1552:
URL: https://github.com/apache/incubator-eventmesh/pull/1552

   Made changes for fetching value using the key from the map as per suggestion in #1526 
   
   Fixes #1526 
   
   ### Documentation
   
   - Does this pull request introduces a new feature? no
   - If yes, how is the feature documented? not applicable
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #1552: [ISSUE #1526] update all map fetch value

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #1552:
URL: https://github.com/apache/incubator-eventmesh/pull/1552#issuecomment-1276953505

   please solve the conflict @venu-prasanna 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] fengyongshe commented on pull request #1552: [ISSUE #1526] update all map fetch value

Posted by GitBox <gi...@apache.org>.
fengyongshe commented on PR #1552:
URL: https://github.com/apache/incubator-eventmesh/pull/1552#issuecomment-1277265619

   @xwm1992  SimpleMessage in grpc proto is in wrong status after generated .
   > Task :eventmesh-common:compileJava FAILED
   FAILURE: Build failed with an exception.
   
   ```
   /Users/fys/project/test/incubator-eventmesh/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/grpc/protos/SimpleMessage.java:81: 错误: 程序包RFequestHeader不存在
                           RFequestHeader.Builder subBuilder = null;
                                         ^
   ```
   
   This's should be a wrong merge.  This is no R**F**equestHeader ( Should be RequestHandler )  . 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1552: [ISSUE #1526] update all map fetch value

Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1552:
URL: https://github.com/apache/incubator-eventmesh/pull/1552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] horoc commented on pull request #1552: [ISSUE #1526] update all map fetch value

Posted by GitBox <gi...@apache.org>.
horoc commented on PR #1552:
URL: https://github.com/apache/incubator-eventmesh/pull/1552#issuecomment-1277085394

   hi,@venu-prasanna , may I know why this pr modify GRCP proto generate file? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org