You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/04/02 06:53:36 UTC
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#931: [IOTDB-540]Add time filter for LAST query and refactor Previous Fill
qiaojialin commented on a change in pull request #931: [IOTDB-540]Add time filter for LAST query and refactor Previous Fill
URL: https://github.com/apache/incubator-iotdb/pull/931#discussion_r402011493
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/FillQueryExecutor.java
##########
@@ -89,9 +89,10 @@ public QueryDataSet execute(QueryContext context, FillQueryPlan fillQueryPlan)
} else {
fill = typeIFillMap.get(dataType).copy();
}
- configureFill(fill, dataType, path, fillQueryPlan.getAllSensorsInDevice(path.getDevice()), context, queryTime);
+ fill.configureFill(path, dataType, queryTime,
+ fillQueryPlan.getAllSensorsInDevice(path.getDevice()), context);
- TimeValuePair timeValuePair = fill.getFillResult();
+ TimeValuePair timeValuePair = fill.getFillResult(context);
Review comment:
store context in FIll, remove the parameter in getFillResult
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services