You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2023/04/14 04:42:29 UTC

[GitHub] [hudi] codope commented on a diff in pull request #7627: [HUDI-5517] HoodieTimeline support filter instants by state transition time

codope commented on code in PR #7627:
URL: https://github.com/apache/hudi/pull/7627#discussion_r1166270869


##########
hudi-common/src/main/avro/HoodieArchivedMetaEntry.avsc:
##########
@@ -128,6 +128,11 @@
             "HoodieIndexCommitMetadata"
          ],
          "default": null
+      },
+      {
+         "name":"stateTransitionTime",
+         "type":["null","string"],
+         "default": null

Review Comment:
   +1 we should save it in the archived metadata. I can see other potential use cases when there can be holes in the timeline after we allow archival beyond savepoint. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org