You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/02 22:32:51 UTC

[GitHub] [spark] ueshin commented on a change in pull request #33901: [SPARK-36655][PYTHON] Add `versionadded` for API added in Spark 3.3.0

ueshin commented on a change in pull request #33901:
URL: https://github.com/apache/spark/pull/33901#discussion_r701463437



##########
File path: python/pyspark/pandas/indexes/category.py
##########
@@ -645,6 +645,8 @@ def map(  # type: ignore[override]
         If a `dict` or `Series` is used any unmapped category is mapped to missing values.
         Note that if this happens an `Index` will be returned.
 
+        versionadded:: 3.3.0

Review comment:
       ditto.
   
   https://github.com/apache/spark/blob/branch-3.2/python/pyspark/pandas/indexes/category.py#L634-L706

##########
File path: python/pyspark/pandas/indexes/base.py
##########
@@ -527,6 +527,8 @@ def map(
         """
         Map values using input correspondence (a dict, Series, or function).
 
+        versionadded:: 3.3.0

Review comment:
       We don't need this because `Index.map` was merged to 3.2 as well.
   
   https://github.com/apache/spark/blob/branch-3.2/python/pyspark/pandas/indexes/base.py#L524-L566




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org