You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/08/28 02:44:11 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #580:
[SCB-1441] [Syncer] Support for tls certificates when loading instance data
from servicecenter
codecov-io commented on issue #580: [SCB-1441] [Syncer] Support for tls certificates when loading instance data from servicecenter
URL: https://github.com/apache/servicecomb-service-center/pull/580#issuecomment-525560566
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=h1) Report
> Merging [#580](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/9c0e0582920c5e74b934226469d9d9d9cc456020?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 57.85% 57.77% -0.08%
==========================================
Files 203 204 +1
Lines 15656 15699 +43
==========================================
+ Hits 9057 9070 +13
- Misses 5951 5982 +31
+ Partials 648 647 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/plugins/option.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvb3B0aW9uLmdv) | `0% <0%> (ø)` | |
| [syncer/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc2VydmljZWNlbnRlci5nbw==) | `86.36% <100%> (ø)` | :arrow_up: |
| [syncer/plugins/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9zZXJ2aWNlY2VudGVyLmdv) | `88.88% <100%> (ø)` | :arrow_up: |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `47.88% <44%> (-7.67%)` | :arrow_down: |
| [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `69.44% <0%> (-9.73%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
| [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `53.57% <0%> (-0.72%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=footer). Last update [9c0e058...1860a4e](https://codecov.io/gh/apache/servicecomb-service-center/pull/580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services