[jira] [Commented] (NIFI-3101) Improvements with URL property of Get/Modify/PutHTMLElement

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695326#comment-15695326 ] 

ASF GitHub Bot commented on NIFI-3101:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1271

    NIFI-3101: Improve Get/Modify/PutHTMLElement URL

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    - Added detailed description about how the URL property works with
      GetHTMLElement
    - Added Expression support with URL
    - Made URL property dynamic with ModifyHTMLElement and PutHTMLElement,
      since it won't be used to alter HTML element and need not to be
      specified. Making it a dynamic property let existing processor configuration stays valid

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-3101

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1271
    
----
commit 0efe56928d0b341fe6ec979981c727c9852ad135
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-11-25T08:58:32Z

    NIFI-3101: Improve Get/Modify/PutHTMLElement URL
    
    - Added detailed description about how the URL property works with
      GetHTMLElement
    - Added Expression support with URL
    - Made URL property dynamic with ModifyHTMLElement and PutHTMLElement,
      since it won't be used to alter HTML element and need not to be
      specified. Making it a dynamic property let existing processor configuration stays valid

----


> Improvements with URL property of Get/Modify/PutHTMLElement
> -----------------------------------------------------------
>
>                 Key: NIFI-3101
>                 URL: https://issues.apache.org/jira/browse/NIFI-3101
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Koji Kawamura
>            Priority: Minor
>
> For some users (including me), it was not clear how to make use of the URL property of Get/Modify/PutHTMLElement.
> It can be used to replace relative URL when you get/set attribute value of HTML element, such as src of img tag. To make the URL property works as expected, you also have specify 'abs:' prefix with the target HTML tag attribute value, like 'abs:src'.
> It makes easier for people to use these processors if we provide more description on the URL property.
> Also, it can be more useful if the URL property supports NiFi Expression Language.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)