[GitHub] rdelval edited a comment on issue #37: Staggered (Variable batch) Updates

[GitBox <gi...@apache.org>]

rdelval edited a comment on issue #37: Staggered (Variable batch) Updates
URL: https://github.com/apache/aurora/pull/37#issuecomment-423557568
 
 
   @StephanErb updated the PR to address feedback. Thank you very much for the feedback, it helped me realize rollback was not exactly a mirror image of roll forward. I've addressed that with this update.
   
   Edit- Forgot to mention. I've also added a conversion from the old thrift schema to the new thrift schema upon receiving the request. 
   
   You had asked me to remove it in a previous review but we realized (when we tried to deploy this patch internally) that we can't upgrade clients as quickly in our usecase. Since we use a go library for communicating to Aurora, we have to recompile all our programs with support for the new thrift schema. These few lines of code I added back would provide a pretty seamless transition from 0.21.0 to 0.22.0 while clients are updated and would be removed in 0.23.0.
   
   It is a bit of kicking the upgrade down the road a bit but the buffer gives us time to upgrade client code.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services