[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #363: HDDS-2679. Ratis ring creation might be failed with async pipeline creation.

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #363: HDDS-2679. Ratis ring creation might be failed with async pipeline creation.
URL: https://github.com/apache/hadoop-ozone/pull/363#discussion_r358140276
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java
 ##########
 @@ -157,12 +157,11 @@ public Pipeline create(ReplicationFactor factor) throws IOException {
         new CreatePipelineCommand(pipeline.getId(), pipeline.getType(),
             factor, dns);
 
-    dns.stream().forEach(node -> {
-      final CommandForDatanode datanodeCommand =
-          new CommandForDatanode<>(node.getUuid(), createCommand);
+    dns.forEach(node -> {
       LOG.info("Send pipeline:{} create command to datanode {}",
 
 Review comment:
   Thanks for the review @swagle 
   This is SCM part and we are not explicitly calling groupAdd from here. We are queuing datanode command to create the pipeline.
   I will rephrase it to `Sending CreatePipelineCommand for pipeline:{} to datanode: {}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org