You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org> on 2018/05/14 23:52:05 UTC
[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 )
Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates
......................................................................
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG@7
PS8, Line 7: Update
> Please add a space in front of this.
Done
http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py
File tests/benchmark/perf_result_datastore.py:
http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py@298
PS5, Line 298: LOG.debug('Inserting File Type: {0}, {1}, {2}'.format(
> Fix indentation
Done
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@141
PS8, Line 141: Dont
> I think either "Don't" or "Do not" is better than Dont. This is used for us
Done
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@1058
PS8, Line 1058: if exec_summaries[0] is None:
: return ""
> I think this is a redundant special handling. I believe L1054-1055 can be
Done
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 May 2018 23:52:05 +0000
Gerrit-HasComments: Yes