You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/16 04:43:38 UTC
[GitHub] [kafka] NLincoln opened a new pull request, #12863: KAFKA-14358 Do not allow users to create the metadata topic
NLincoln opened a new pull request, #12863:
URL: https://github.com/apache/kafka/pull/12863
Wanted to try contributing a patch, so here I am :). I noticed that the jira was already assigned, but hadn't had some activity for a bit, so I figured I'd give it a try.
This technically introduces the concept of a "reserved topic", which might not be a good thing? Not sure how these changes are usually handled.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12863:
URL: https://github.com/apache/kafka/pull/12863#issuecomment-1320238030
@NLincoln It looks like this issue was already assigned to @jsancio on Jira; it's best to find tickets that either have not yet been assigned, or have not been worked on in a while.
@jsancio since this addresses a blocker for 3.3.2, would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic
Posted by GitBox <gi...@apache.org>.
jsancio commented on PR #12863:
URL: https://github.com/apache/kafka/pull/12863#issuecomment-1322644819
Thanks @NLincoln . I'll take a look. I didn't see this PR so I just created https://github.com/apache/kafka/pull/12885.
My preliminary concern is that `detectInvalidTopic` is used a a few places in Kafka. I think we should just restrict the ability of the user to create a topic with this name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] NLincoln closed pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic
Posted by GitBox <gi...@apache.org>.
NLincoln closed pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic
URL: https://github.com/apache/kafka/pull/12863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org