[GitHub] jerrypeng opened a new pull request #3299: Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks

[GitBox <gi...@apache.org>]

jerrypeng opened a new pull request #3299:  Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks
URL: https://github.com/apache/pulsar/pull/3299
 
 
   ### Motivation
   
   Consumer subscriptions are not cleanup when functions/sinks are terminated which can be a headache for admins to do this manually.  Because subscriptions are left over, topics never get cleaned up.  
   
   In this PR, I created a flag "cleanupSubscription" that indicates whether the subscriptions created by the function should be removed on terminate.  The flag is set to true by default, since I think that is probably going to be the normal use case.
   
   To correctly implement the above behavior, I had to fix the shutdown process of function processes.  There is no graceful shutdown period for functions/sinks/sources in which we can unsubscribe, thus I had to add that as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services