You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Bernardo Gomez Palacio <be...@gmail.com> on 2014/05/03 01:53:07 UTC

Review Request 21044: [MESOS-1261]: Porting Protobuf shading to 0.17.x

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21044/
-----------------------------------------------------------

Review request for mesos and Mesos ReviewBot.

Bugs: MESOS-1261
https://issues.apache.org/jira/browse/MESOS-1261

Repository: mesos-git

Description
-------

This commit adds support for protobuf shading to 0.17.0.

I ran into some trouble submitting this review and the result is a patch that bundles what should really be three. The original intention was to base this patch on 1094c1baba95e2fce8ce76b8f46967774dde5a35:"Updated the CHANGELOG for releasing 0.17.0." but I kept getting errors from RB. The solution, not perfect, was to base this patch on c0527bb28b4e3c102112f46269bb594c1bfd1350:"Used interval set to store holes and unlearned positions in replica." which went through RB (https://reviews.apache.org/r/17866).

All said this patch can be applied directly to 1094c1baba95e2fce8ce76b8f46967774dde5a35. I would assume that a branch that targets 0.17.1 will be created and will include this patch.

This commit merges:

[MESOS-1252]: Support ENV MAVEN_HOME on the build.

The build now supports the `MAVEN_HOME` environment variable which is
used to resolve the `mvn` executable. If no `MAVEN_HOME` is specified we
will use the one available in the `PATH`.

ticket: https://issues.apache.org/jira/browse/MESOS-1252

Fixed distclean break during maven clean up.

The pom file gets cleaned up before clean-java runs, which calls maven
and fails. Solution is to just remove the target dir, which is what
maven does as well.

[PATCH] [MESOS-1259]: Enrich the Java Docs in the src/java files.

The Maven _package_ task will depends on the _javadoc:javadoc_ task. The
_javadoc_ task fails if there are _Classes_ which expose _public_ fields
or methods without proper _Java Documentation_. Note that by proper I am
referring to the structure that is validated by the _Javadoc Tool_.

In addition such documentation should facilitate the development of Java
based frameworks.

Diffs
-----

configure.ac aa6ee45bc477dd81b6f0cb389ef9f16f8216d6df
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/examples/java/test-exception-framework.in 26617e23b9e820a48f9dd7f746cd8ee42693763c
src/examples/java/test-executor.in 8b27a37ec23cab2145b46ed926cdf148e2fa2da0
src/examples/java/test-framework.in bbdc1ed79c152dab0972bb4043126fa61c601435
src/examples/java/test-multiple-executors-framework.in eb8edf6ff5b93013c859b1ee93d427814ef4a2ba
src/java/MESOS-MAVEN-README 2da664649092d5050352d5362938c57f05e52b86
src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
src/java/src/org/apache/mesos/Executor.java 8f4eaeeea0f96927e67b746e506310555e0e9a05
src/java/src/org/apache/mesos/ExecutorDriver.java cb14f38e9ffcc382b2bba8fb725b5a87f5f6f4f0
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 55c4706c86ed68f13a9a33168381165900f7cfcf
src/java/src/org/apache/mesos/SchedulerDriver.java 6bca8799f2515d295cfeebf5ec6aab930f7c8b80
src/java/src/org/apache/mesos/state/State.java dccb0ff0fa9f0e456e3ff2657520aee2ae2a7f5e
src/java/src/org/apache/mesos/state/Variable.java bedb74b5aaafa7e2bb304f44e3bb972445edceca
src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f73192d2cec470ca1a7ff35e7b0a9b93a6

Diff: https://reviews.apache.org/r/21044/diff/

Testing
-------

1. ./bootstrap && mkdir build && cd build && ../configure && make && make check
2. Ensure the existence of
build/src/java/target/mesos-0.17.0-javadoc.jar
build/src/java/target/mesos-0.17.0-shaded-protobuf.jar
build/src/java/target/mesos-0.17.0-sources.jar
build/src/java/target/mesos-0.17.0.jar
build/src/java/target/protobuf-java-2.5.0.jar
3. do a `jar tvf build/src/java/target/mesos-0.16.0-shaded-protobuf.jar | grep protobuf | grep .class` and you should see the protobuf classes inside the org.apache.mesos.protobuf namespace.

Thanks,

Bernardo Gomez Palacio

Re: Review Request 21044: [MESOS-1261]: Porting Protobuf shading to 0.17.x

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21044/#review42091
-----------------------------------------------------------


It's awesome you have this for both 0.16 and 0.17! See my comment for how I think we should proceed in https://reviews.apache.org/r/21051.

- Benjamin Hindman


On May 3, 2014, 12:48 a.m., Bernardo Gomez Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21044/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 12:48 a.m.)
> 
> 
> Review request for mesos and Mesos ReviewBot.
> 
> 
> Bugs: MESOS-1261
>     https://issues.apache.org/jira/browse/MESOS-1261
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This commit adds support for protobuf shading to 0.17.0.
> 
> I ran into some trouble submitting this review and the result is a patch that bundles what should really be three. The original intention was to base this patch on 1094c1baba95e2fce8ce76b8f46967774dde5a35:"Updated the CHANGELOG for releasing 0.17.0." but I kept getting errors from RB. The solution, not perfect, was to base this patch on c0527bb28b4e3c102112f46269bb594c1bfd1350:"Used interval set to store holes and unlearned positions in replica." which went through RB (https://reviews.apache.org/r/17866). 
> 
> All said this patch can be applied directly to 1094c1baba95e2fce8ce76b8f46967774dde5a35. I would assume that a branch that targets 0.17.1 will be created and will include this patch.
> 
> This commit merges:
> 
> [MESOS-1252]: Support ENV MAVEN_HOME on the build.
> 
> The build now supports the `MAVEN_HOME` environment variable which is
> used to resolve the `mvn` executable. If no `MAVEN_HOME` is specified we
> will use the one available in the `PATH`.
> 
> ticket: https://issues.apache.org/jira/browse/MESOS-1252
> 
> Fixed distclean break during maven clean up.
> 
> The pom file gets cleaned up before clean-java runs, which calls maven
> and fails. Solution is to just remove the target dir, which is what
> maven does as well.
> 
> [PATCH] [MESOS-1259]: Enrich the Java Docs in the src/java files.
> 
> The Maven _package_ task will depends on the _javadoc:javadoc_ task. The
> _javadoc_ task fails if there are _Classes_ which expose _public_ fields
> or methods without proper _Java Documentation_. Note that by proper I am
> referring to the structure that is validated by the _Javadoc Tool_.
> 
> In addition such documentation should facilitate the development of Java
> based frameworks.
> 
> 
> Diffs
> -----
> 
>   configure.ac aa6ee45bc477dd81b6f0cb389ef9f16f8216d6df 
>   src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 
>   src/examples/java/test-exception-framework.in 26617e23b9e820a48f9dd7f746cd8ee42693763c 
>   src/examples/java/test-executor.in 8b27a37ec23cab2145b46ed926cdf148e2fa2da0 
>   src/examples/java/test-framework.in bbdc1ed79c152dab0972bb4043126fa61c601435 
>   src/examples/java/test-multiple-executors-framework.in eb8edf6ff5b93013c859b1ee93d427814ef4a2ba 
>   src/java/MESOS-MAVEN-README 2da664649092d5050352d5362938c57f05e52b86 
>   src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b 
>   src/java/src/org/apache/mesos/Executor.java 8f4eaeeea0f96927e67b746e506310555e0e9a05 
>   src/java/src/org/apache/mesos/ExecutorDriver.java cb14f38e9ffcc382b2bba8fb725b5a87f5f6f4f0 
>   src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3 
>   src/java/src/org/apache/mesos/Scheduler.java 55c4706c86ed68f13a9a33168381165900f7cfcf 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 6bca8799f2515d295cfeebf5ec6aab930f7c8b80 
>   src/java/src/org/apache/mesos/state/State.java dccb0ff0fa9f0e456e3ff2657520aee2ae2a7f5e 
>   src/java/src/org/apache/mesos/state/Variable.java bedb74b5aaafa7e2bb304f44e3bb972445edceca 
>   src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f73192d2cec470ca1a7ff35e7b0a9b93a6 
> 
> Diff: https://reviews.apache.org/r/21044/diff/
> 
> 
> Testing
> -------
> 
> 1. ./bootstrap && mkdir build && cd build && ../configure && make && make check
> 2. Ensure the existence of 
> build/src/java/target/mesos-0.17.0-javadoc.jar
> build/src/java/target/mesos-0.17.0-shaded-protobuf.jar
> build/src/java/target/mesos-0.17.0-sources.jar
> build/src/java/target/mesos-0.17.0.jar
> build/src/java/target/protobuf-java-2.5.0.jar
> 3. do a `jar tvf build/src/java/target/mesos-0.17.0-shaded-protobuf.jar | grep protobuf | grep .class` and you should see the protobuf classes inside the org.apache.mesos.protobuf namespace.
> 
> 
> Thanks,
> 
> Bernardo Gomez Palacio
> 
>

Re: Review Request 21044: [MESOS-1261]: Porting Protobuf shading to 0.17.x

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21044/#review42116
-----------------------------------------------------------


Bad patch!

Reviews applied: [21044]

Failed command: git apply --index 21044.patch

Error:
 error: patch failed: configure.ac:151
error: configure.ac: patch does not apply
error: patch failed: src/Makefile.am:523
error: src/Makefile.am: patch does not apply
error: patch failed: src/examples/java/test-exception-framework.in:12
error: src/examples/java/test-exception-framework.in: patch does not apply
error: patch failed: src/examples/java/test-executor.in:12
error: src/examples/java/test-executor.in: patch does not apply
error: patch failed: src/examples/java/test-framework.in:12
error: src/examples/java/test-framework.in: patch does not apply
error: patch failed: src/examples/java/test-multiple-executors-framework.in:12
error: src/examples/java/test-multiple-executors-framework.in: patch does not apply
error: patch failed: src/java/MESOS-MAVEN-README:7
error: src/java/MESOS-MAVEN-README: patch does not apply
error: patch failed: src/java/mesos.pom.in:94
error: src/java/mesos.pom.in: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/Executor.java:29
error: src/java/src/org/apache/mesos/Executor.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/ExecutorDriver.java:31
error: src/java/src/org/apache/mesos/ExecutorDriver.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/Scheduler.java:43
error: src/java/src/org/apache/mesos/Scheduler.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/SchedulerDriver.java:34
error: src/java/src/org/apache/mesos/SchedulerDriver.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/state/State.java:23
error: src/java/src/org/apache/mesos/state/State.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/state/Variable.java:23
error: src/java/src/org/apache/mesos/state/Variable.java: patch does not apply
error: patch failed: src/java/src/org/apache/mesos/state/ZooKeeperState.java:45
error: src/java/src/org/apache/mesos/state/ZooKeeperState.java: patch does not apply


- Mesos ReviewBot


On May 3, 2014, 12:48 a.m., Bernardo Gomez Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21044/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 12:48 a.m.)
> 
> 
> Review request for mesos and Mesos ReviewBot.
> 
> 
> Bugs: MESOS-1261
>     https://issues.apache.org/jira/browse/MESOS-1261
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This commit adds support for protobuf shading to 0.17.0.
> 
> I ran into some trouble submitting this review and the result is a patch that bundles what should really be three. The original intention was to base this patch on 1094c1baba95e2fce8ce76b8f46967774dde5a35:"Updated the CHANGELOG for releasing 0.17.0." but I kept getting errors from RB. The solution, not perfect, was to base this patch on c0527bb28b4e3c102112f46269bb594c1bfd1350:"Used interval set to store holes and unlearned positions in replica." which went through RB (https://reviews.apache.org/r/17866). 
> 
> All said this patch can be applied directly to 1094c1baba95e2fce8ce76b8f46967774dde5a35. I would assume that a branch that targets 0.17.1 will be created and will include this patch.
> 
> This commit merges:
> 
> [MESOS-1252]: Support ENV MAVEN_HOME on the build.
> 
> The build now supports the `MAVEN_HOME` environment variable which is
> used to resolve the `mvn` executable. If no `MAVEN_HOME` is specified we
> will use the one available in the `PATH`.
> 
> ticket: https://issues.apache.org/jira/browse/MESOS-1252
> 
> Fixed distclean break during maven clean up.
> 
> The pom file gets cleaned up before clean-java runs, which calls maven
> and fails. Solution is to just remove the target dir, which is what
> maven does as well.
> 
> [PATCH] [MESOS-1259]: Enrich the Java Docs in the src/java files.
> 
> The Maven _package_ task will depends on the _javadoc:javadoc_ task. The
> _javadoc_ task fails if there are _Classes_ which expose _public_ fields
> or methods without proper _Java Documentation_. Note that by proper I am
> referring to the structure that is validated by the _Javadoc Tool_.
> 
> In addition such documentation should facilitate the development of Java
> based frameworks.
> 
> 
> Diffs
> -----
> 
>   configure.ac aa6ee45bc477dd81b6f0cb389ef9f16f8216d6df 
>   src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 
>   src/examples/java/test-exception-framework.in 26617e23b9e820a48f9dd7f746cd8ee42693763c 
>   src/examples/java/test-executor.in 8b27a37ec23cab2145b46ed926cdf148e2fa2da0 
>   src/examples/java/test-framework.in bbdc1ed79c152dab0972bb4043126fa61c601435 
>   src/examples/java/test-multiple-executors-framework.in eb8edf6ff5b93013c859b1ee93d427814ef4a2ba 
>   src/java/MESOS-MAVEN-README 2da664649092d5050352d5362938c57f05e52b86 
>   src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b 
>   src/java/src/org/apache/mesos/Executor.java 8f4eaeeea0f96927e67b746e506310555e0e9a05 
>   src/java/src/org/apache/mesos/ExecutorDriver.java cb14f38e9ffcc382b2bba8fb725b5a87f5f6f4f0 
>   src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3 
>   src/java/src/org/apache/mesos/Scheduler.java 55c4706c86ed68f13a9a33168381165900f7cfcf 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 6bca8799f2515d295cfeebf5ec6aab930f7c8b80 
>   src/java/src/org/apache/mesos/state/State.java dccb0ff0fa9f0e456e3ff2657520aee2ae2a7f5e 
>   src/java/src/org/apache/mesos/state/Variable.java bedb74b5aaafa7e2bb304f44e3bb972445edceca 
>   src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f73192d2cec470ca1a7ff35e7b0a9b93a6 
> 
> Diff: https://reviews.apache.org/r/21044/diff/
> 
> 
> Testing
> -------
> 
> 1. ./bootstrap && mkdir build && cd build && ../configure && make && make check
> 2. Ensure the existence of 
> build/src/java/target/mesos-0.17.0-javadoc.jar
> build/src/java/target/mesos-0.17.0-shaded-protobuf.jar
> build/src/java/target/mesos-0.17.0-sources.jar
> build/src/java/target/mesos-0.17.0.jar
> build/src/java/target/protobuf-java-2.5.0.jar
> 3. do a `jar tvf build/src/java/target/mesos-0.17.0-shaded-protobuf.jar | grep protobuf | grep .class` and you should see the protobuf classes inside the org.apache.mesos.protobuf namespace.
> 
> 
> Thanks,
> 
> Bernardo Gomez Palacio
> 
>

Re: Review Request 21044: [MESOS-1261]: Porting Protobuf shading to 0.17.x

Posted by Bernardo Gomez Palacio <be...@gmail.com>.

(Updated May 3, 2014, 12:48 a.m.)

Review request for mesos and Mesos ReviewBot.

Changes
-------

typo on version.

Bugs: MESOS-1261
https://issues.apache.org/jira/browse/MESOS-1261

Repository: mesos-git

Description
-------

This commit adds support for protobuf shading to 0.17.0.

All said this patch can be applied directly to 1094c1baba95e2fce8ce76b8f46967774dde5a35. I would assume that a branch that targets 0.17.1 will be created and will include this patch.

This commit merges:

[MESOS-1252]: Support ENV MAVEN_HOME on the build.

The build now supports the `MAVEN_HOME` environment variable which is
used to resolve the `mvn` executable. If no `MAVEN_HOME` is specified we
will use the one available in the `PATH`.

ticket: https://issues.apache.org/jira/browse/MESOS-1252

Fixed distclean break during maven clean up.

The pom file gets cleaned up before clean-java runs, which calls maven
and fails. Solution is to just remove the target dir, which is what
maven does as well.

[PATCH] [MESOS-1259]: Enrich the Java Docs in the src/java files.

In addition such documentation should facilitate the development of Java
based frameworks.

Diffs
-----

Diff: https://reviews.apache.org/r/21044/diff/

Testing (updated)
-------

1. ./bootstrap && mkdir build && cd build && ../configure && make && make check
2. Ensure the existence of
build/src/java/target/mesos-0.17.0-javadoc.jar
build/src/java/target/mesos-0.17.0-shaded-protobuf.jar
build/src/java/target/mesos-0.17.0-sources.jar
build/src/java/target/mesos-0.17.0.jar
build/src/java/target/protobuf-java-2.5.0.jar
3. do a `jar tvf build/src/java/target/mesos-0.17.0-shaded-protobuf.jar | grep protobuf | grep .class` and you should see the protobuf classes inside the org.apache.mesos.protobuf namespace.

Thanks,

Bernardo Gomez Palacio