You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/15 14:45:30 UTC
[GitHub] Oh233 commented on a change in pull request #12178: fix flasky
unittest for deformable psroi pooling
Oh233 commented on a change in pull request #12178: fix flasky unittest for deformable psroi pooling
URL: https://github.com/apache/incubator-mxnet/pull/12178#discussion_r210292861
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -5010,15 +5067,11 @@ def test_deformable_psroipooling():
sample_per_part=4, group_size=num_group,
pooled_size=num_group, output_dim=num_classes,
trans_std=0.1, no_trans=False, name='test_op')
- if grad_nodes[0] == 'offset_data':
- # wider tolerance needed for coordinate differential
- rtol, atol = 1.0, 1e-2
- else:
- rtol, atol = 1e-2, 1e-3
+ rtol, atol = 1e-2, 1e-3
# By now we only have gpu implementation
if default_context().device_type == 'gpu':
check_numeric_gradient(op, [im_data, rois_data, offset_data], rtol=rtol, atol=atol,
- grad_nodes=grad_nodes, ctx=mx.gpu(0))
+ grad_nodes=grad_nodes, ctx=mx.gpu(1))
Review comment:
Sorry, this is not intentional. I fixed it already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services