You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Stefano Mazzocchi <st...@apache.org> on 2006/11/11 02:28:43 UTC
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
gshimansky@apache.org wrote:
> Author: gshimansky
> Date: Fri Nov 10 16:17:50 2006
> New Revision: 473588
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
> Log:
> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have been committed
>
> Since x86_64 is not yet fully supported and patch touched only x86_64 files no
> tests were ran. When I tried acceptance tests on em64t server I effectively
> shut it down.
> Modified: incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h
> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
> ==============================================================================
> --- incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h (original)
> +++ incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h Fri Nov 10 16:17:50 2006
> @@ -18,6 +18,6 @@
> #ifndef _VERSION_SVN_TAG_
> #define _VERSION_SVN_TAG_
>
> -#define VERSION_SVN_TAG "473506"
> +#define VERSION_SVN_TAG "svn: This client is too old to work with working copy '.'; please get a newer Subversion client"
uh?
--
Stefano.
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Pavel Pervov <pm...@gmail.com>.
It looks like host, which Gregory used for EM64T build, has svn of outdated
version.
Generally, version_svn_tag.h should not be committed at all.
On 11/11/06, Stefano Mazzocchi <st...@apache.org> wrote:
>
> gshimansky@apache.org wrote:
> > Author: gshimansky
> > Date: Fri Nov 10 16:17:50 2006
> > New Revision: 473588
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=473588
> > Log:
> > Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have been
> committed
> >
> > Since x86_64 is not yet fully supported and patch touched only x86_64
> files no
> > tests were ran. When I tried acceptance tests on em64t server I
> effectively
> > shut it down.
>
>
> > Modified:
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h
> > URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
> >
> ==============================================================================
> > ---
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h
> (original)
> > +++
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.h
> Fri Nov 10 16:17:50 2006
> > @@ -18,6 +18,6 @@
> > #ifndef _VERSION_SVN_TAG_
> > #define _VERSION_SVN_TAG_
> >
> > -#define VERSION_SVN_TAG "473506"
> > +#define VERSION_SVN_TAG "svn: This client is too old to work with
> working copy '.'; please get a newer Subversion client"
>
> uh?
>
> --
> Stefano.
>
>
--
Pavel Pervov,
Intel Enterprise Solutions Software Division
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Thats what I thought I suggested, but don't see the email now...
Stefano Mazzocchi wrote:
> Geir Magnusson Jr. wrote:
>>
>> Gregory Shimansky wrote:
>>> On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
>>>> gshimansky@apache.org wrote:
>>>>> Author: gshimansky
>>>>> Date: Fri Nov 10 16:17:50 2006
>>>>> New Revision: 473588
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
>>>>> Log:
>>>>> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have
>>>>> been
>>>>> committed
>>>>>
>>>>> Since x86_64 is not yet fully supported and patch touched only x86_64
>>>>> files no tests were ran. When I tried acceptance tests on em64t
>>>>> server I
>>>>> effectively shut it down.
>>>>>
>>>>>
>>>>> Modified:
>>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>>
>>>>> h URL:
>>>>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
>>>>>
>>>>> core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
>>>>> =========================================================================
>>>>>
>>>>> ===== ---
>>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>>
>>>>> h (original) +++
>>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>>
>>>>> h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
>>>>> #ifndef _VERSION_SVN_TAG_
>>>>> #define _VERSION_SVN_TAG_
>>>>>
>>>>> -#define VERSION_SVN_TAG "473506"
>>>>> +#define VERSION_SVN_TAG "svn: This client is too old to work with
>>>>> working copy '.'; please get a newer Subversion client"
>>>> uh?
>>> Ok it seems like svn version on the x86_64 server was too old for the
>>> checked out repository. Don't worry, the version file will be fixed
>>> with a next commit to VM.
>>>
>>> It looks like we should really autogenerate it and remove it from svn
>>> as was suggested in another thread.
>>>
>> It is autogenerated. We just need to stop committing it...
>
> ehm, how about using svn:ignore then ;-)
>
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Stefano Mazzocchi <st...@apache.org>.
Geir Magnusson Jr. wrote:
>
>
> Gregory Shimansky wrote:
>> On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
>>> gshimansky@apache.org wrote:
>>>> Author: gshimansky
>>>> Date: Fri Nov 10 16:17:50 2006
>>>> New Revision: 473588
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
>>>> Log:
>>>> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have
>>>> been
>>>> committed
>>>>
>>>> Since x86_64 is not yet fully supported and patch touched only x86_64
>>>> files no tests were ran. When I tried acceptance tests on em64t
>>>> server I
>>>> effectively shut it down.
>>>>
>>>>
>>>> Modified:
>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>
>>>> h URL:
>>>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
>>>>
>>>> core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
>>>> =========================================================================
>>>>
>>>> ===== ---
>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>
>>>> h (original) +++
>>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>>>
>>>> h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
>>>> #ifndef _VERSION_SVN_TAG_
>>>> #define _VERSION_SVN_TAG_
>>>>
>>>> -#define VERSION_SVN_TAG "473506"
>>>> +#define VERSION_SVN_TAG "svn: This client is too old to work with
>>>> working copy '.'; please get a newer Subversion client"
>>> uh?
>>
>> Ok it seems like svn version on the x86_64 server was too old for the
>> checked out repository. Don't worry, the version file will be fixed
>> with a next commit to VM.
>>
>> It looks like we should really autogenerate it and remove it from svn
>> as was suggested in another thread.
>>
>
> It is autogenerated. We just need to stop committing it...
ehm, how about using svn:ignore then ;-)
--
Stefano.
Re: Deleted version_svn_tag.h
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Salikh Zakirov wrote:
> Nathan Beyer wrote:
>> Not using SVN directly? Do I even want to ask?
>
> We have a running SVN->Git mirroring via tailor, and some people
> prefer to use Git for managing patches, because git
> 1) is faster 2) can manage many patches and branches 3) can work offline.
> (I do not intend this as hidden advertisment, sorry if it sounds like it).
It doesn't matter. We use SVN :)
>
>> In any case, I tested it after I deleted the file and the file was
>> regenerated during the build. Did I miss something? I thought this bit
>> was already in the scripts.
>
> Nathan, thanks a lot for you attention!
>
> I do not think you missed anything, because it is really due to
> peculiarities in our setup. When SVN information is not available,
> pointless file copying wasn't performed, and this was also feature
> requested by me (to shorten recompilation time).
>
> Since the fix was committed promptly, I really don't see much problem
> in this particular case, and do not see anything that you need to change
> in your process.
>
Yah - nothing has to change. There's nothing to see here. :)
geir
> Thanks for the care, anyway.
>
>
Re: Deleted version_svn_tag.h
Posted by Salikh Zakirov <Sa...@Intel.com>.
Nathan Beyer wrote:
> Not using SVN directly? Do I even want to ask?
We have a running SVN->Git mirroring via tailor, and some people
prefer to use Git for managing patches, because git
1) is faster 2) can manage many patches and branches 3) can work offline.
(I do not intend this as hidden advertisment, sorry if it sounds like it).
> In any case, I tested it after I deleted the file and the file was
> regenerated during the build. Did I miss something? I thought this bit
> was already in the scripts.
Nathan, thanks a lot for you attention!
I do not think you missed anything, because it is really due to
peculiarities in our setup. When SVN information is not available,
pointless file copying wasn't performed, and this was also feature
requested by me (to shorten recompilation time).
Since the fix was committed promptly, I really don't see much problem
in this particular case, and do not see anything that you need to change
in your process.
Thanks for the care, anyway.
Re: Deleted version_svn_tag.h
Posted by Nathan Beyer <nb...@gmail.com>.
Not using SVN directly? Do I even want to ask?
In any case, I tested it after I deleted the file and the file was
regenerated during the build. Did I miss something? I thought this bit
was already in the scripts.
-Nathan
On 11/13/06, Salikh Zakirov <Sa...@intel.com> wrote:
> Nathan Beyer wrote:
> > I deleted the file and added it to the ignore property.
>
> For those of us poor souls not using SVN directly
> this deletion broke the build, as the file version_svn_tag.h
> is not available directly now.
>
> The issue HARMONY-2168 provides a fix: copy the file.
>
>
Re: Deleted version_svn_tag.h
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Patch applied - please test
Salikh Zakirov wrote:
> Nathan Beyer wrote:
>> I deleted the file and added it to the ignore property.
>
> For those of us poor souls not using SVN directly
> this deletion broke the build, as the file version_svn_tag.h
> is not available directly now.
>
> The issue HARMONY-2168 provides a fix: copy the file.
>
>
Deleted version_svn_tag.h
Posted by Salikh Zakirov <Sa...@Intel.com>.
Nathan Beyer wrote:
> I deleted the file and added it to the ignore property.
For those of us poor souls not using SVN directly
this deletion broke the build, as the file version_svn_tag.h
is not available directly now.
The issue HARMONY-2168 provides a fix: copy the file.
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Nathan Beyer <nb...@gmail.com>.
I deleted the file and added it to the ignore property.
For those not familiar with SVN, I would strongly encourage reading
the first couple chapters of the book [1]. It's a very quick read and
extremely helpful.
-Nathan
[1] http://svnbook.red-bean.com/
On 11/12/06, Stefano Mazzocchi <st...@apache.org> wrote:
> Pavel Pervov wrote:
> > Geir,
> >
> > Does SVN support some sort of exclude lists?
>
> Of course, http://svnbook.red-bean.com/en/1.1/ch07s02.html (look for the
> svn:ignore property)
>
> --
> Stefano.
>
>
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Stefano Mazzocchi <st...@apache.org>.
Pavel Pervov wrote:
> Geir,
>
> Does SVN support some sort of exclude lists?
Of course, http://svnbook.red-bean.com/en/1.1/ch07s02.html (look for the
svn:ignore property)
--
Stefano.
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Pavel Pervov <pm...@gmail.com>.
Or better call it ignore lists.
On 11/12/06, Pavel Pervov <pm...@gmail.com> wrote:
>
> Geir,
>
> Does SVN support some sort of exclude lists?
>
>
> On 11/12/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
> >
> >
> >
> > Gregory Shimansky wrote:
> > > On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
> > >> gshimansky@apache.org wrote:
> > >>> Author: gshimansky
> > >>> Date: Fri Nov 10 16:17:50 2006
> > >>> New Revision: 473588
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
> > >>> Log:
> > >>> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have
> > been
> > >>> committed
> > >>>
> > >>> Since x86_64 is not yet fully supported and patch touched only
> > x86_64
> > >>> files no tests were ran. When I tried acceptance tests on em64t
> > server I
> > >>> effectively shut it down.
> > >>>
> > >>>
> > >>> Modified:
> > >>>
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> > >>> h URL:
> > >>>
> > http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
> > >>>
> > core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
> > >>>
> > =========================================================================
> > >>> ===== ---
> > >>>
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> > >>> h (original) +++
> > >>>
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> > >>> h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
> > >>> #ifndef _VERSION_SVN_TAG_
> > >>> #define _VERSION_SVN_TAG_
> > >>>
> > >>> -#define VERSION_SVN_TAG "473506"
> > >>> +#define VERSION_SVN_TAG "svn: This client is too old to work with
> > >>> working copy '.'; please get a newer Subversion client"
> > >> uh?
> > >
> > > Ok it seems like svn version on the x86_64 server was too old for the
> > checked
> > > out repository. Don't worry, the version file will be fixed with a
> > next
> > > commit to VM.
> > >
> > > It looks like we should really autogenerate it and remove it from svn
> > as was
> > > suggested in another thread.
> > >
> >
> > It is autogenerated. We just need to stop committing it...
> >
> > geir
> >
> >
>
>
> --
> Pavel Pervov,
> Intel Enterprise Solutions Software Division
>
--
Pavel Pervov,
Intel Enterprise Solutions Software Division
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Pavel Pervov <pm...@gmail.com>.
Geir,
Does SVN support some sort of exclude lists?
On 11/12/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
>
>
>
> Gregory Shimansky wrote:
> > On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
> >> gshimansky@apache.org wrote:
> >>> Author: gshimansky
> >>> Date: Fri Nov 10 16:17:50 2006
> >>> New Revision: 473588
> >>>
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
> >>> Log:
> >>> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have
> been
> >>> committed
> >>>
> >>> Since x86_64 is not yet fully supported and patch touched only x86_64
> >>> files no tests were ran. When I tried acceptance tests on em64t server
> I
> >>> effectively shut it down.
> >>>
> >>>
> >>> Modified:
> >>>
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >>> h URL:
> >>>
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
> >>>
> core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
> >>>
> =========================================================================
> >>> ===== ---
> >>>
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >>> h (original) +++
> >>>
> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >>> h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
> >>> #ifndef _VERSION_SVN_TAG_
> >>> #define _VERSION_SVN_TAG_
> >>>
> >>> -#define VERSION_SVN_TAG "473506"
> >>> +#define VERSION_SVN_TAG "svn: This client is too old to work with
> >>> working copy '.'; please get a newer Subversion client"
> >> uh?
> >
> > Ok it seems like svn version on the x86_64 server was too old for the
> checked
> > out repository. Don't worry, the version file will be fixed with a next
> > commit to VM.
> >
> > It looks like we should really autogenerate it and remove it from svn as
> was
> > suggested in another thread.
> >
>
> It is autogenerated. We just need to stop committing it...
>
> geir
>
>
--
Pavel Pervov,
Intel Enterprise Solutions Software Division
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Gregory Shimansky wrote:
> On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
>> gshimansky@apache.org wrote:
>>> Author: gshimansky
>>> Date: Fri Nov 10 16:17:50 2006
>>> New Revision: 473588
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=473588
>>> Log:
>>> Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have been
>>> committed
>>>
>>> Since x86_64 is not yet fully supported and patch touched only x86_64
>>> files no tests were ran. When I tried acceptance tests on em64t server I
>>> effectively shut it down.
>>>
>>>
>>> Modified:
>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>> h URL:
>>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
>>> core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
>>> =========================================================================
>>> ===== ---
>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>> h (original) +++
>>> incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
>>> h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
>>> #ifndef _VERSION_SVN_TAG_
>>> #define _VERSION_SVN_TAG_
>>>
>>> -#define VERSION_SVN_TAG "473506"
>>> +#define VERSION_SVN_TAG "svn: This client is too old to work with
>>> working copy '.'; please get a newer Subversion client"
>> uh?
>
> Ok it seems like svn version on the x86_64 server was too old for the checked
> out repository. Don't worry, the version file will be fixed with a next
> commit to VM.
>
> It looks like we should really autogenerate it and remove it from svn as was
> suggested in another thread.
>
It is autogenerated. We just need to stop committing it...
geir
Re: svn commit: r473588 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/ port/src/lil/em64t/pim/ vmcore/include/ vmcore/src/util/em64t/base/
Posted by Gregory Shimansky <gs...@gmail.com>.
On Saturday 11 November 2006 04:28 Stefano Mazzocchi wrote:
> gshimansky@apache.org wrote:
> > Author: gshimansky
> > Date: Fri Nov 10 16:17:50 2006
> > New Revision: 473588
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=473588
> > Log:
> > Applied HARMONY-2152 [drlvm][em64t] build is broken after 1558 have been
> > committed
> >
> > Since x86_64 is not yet fully supported and patch touched only x86_64
> > files no tests were ran. When I tried acceptance tests on em64t server I
> > effectively shut it down.
> >
> >
> > Modified:
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >h URL:
> > http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vm
> >core/include/version_svn_tag.h?view=diff&rev=473588&r1=473587&r2=473588
> > =========================================================================
> >===== ---
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >h (original) +++
> > incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/include/version_svn_tag.
> >h Fri Nov 10 16:17:50 2006 @@ -18,6 +18,6 @@
> > #ifndef _VERSION_SVN_TAG_
> > #define _VERSION_SVN_TAG_
> >
> > -#define VERSION_SVN_TAG "473506"
> > +#define VERSION_SVN_TAG "svn: This client is too old to work with
> > working copy '.'; please get a newer Subversion client"
>
> uh?
Ok it seems like svn version on the x86_64 server was too old for the checked
out repository. Don't worry, the version file will be fixed with a next
commit to VM.
It looks like we should really autogenerate it and remove it from svn as was
suggested in another thread.
--
Gregory Shimansky, Intel Middleware Products Division