You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/04/24 14:17:29 UTC
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/5688
[SPARK-7119][SQL] ScriptTransform should also consider the output data type when no serde used
JIRA: https://issues.apache.org/jira/browse/SPARK-7119
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 script_output_type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5688
----
commit 7b1a00a1dc281870e8779b5153fa1fd1bc797aeb
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-04-24T12:15:11Z
ScriptTransform should also consider the output data type when no serde used.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95930701
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30934/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-96392452
@viirya thanks for so quick fixing, but my concern on `ScriptTransformation` is we don't use the `SerDe` or `InputFormat/OutputFormat` at all, and it seems a hack to me, as we split the string manually by either default delimiter(schemaless), this is actually supposed to be done by `InputFormat/OutputFormat` and `SerDe`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95930691
[Test build #30934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30934/consoleFull) for PR 5688 at commit [`7b1a00a`](https://github.com/apache/spark/commit/7b1a00a1dc281870e8779b5153fa1fd1bc797aeb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95943436
[Test build #30938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30938/consoleFull) for PR 5688 at commit [`a69b1d9`](https://github.com/apache/spark/commit/a69b1d9f0cbbbca44b48107763efed11d31019f6).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95970764
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30938/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-96406187
@chenghao-intel thanks for suggestion. This indeed is just a quick fixing. Since in these test cases, users don't indicate SerDe to use, I will investigate if there is default SerDe for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-96710475
@chenghao-intel I updated the codes.
Seems Avro should not be used in transform syntax, so I marked the related unit test as ignored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95970751
[Test build #30938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30938/consoleFull) for PR 5688 at commit [`a69b1d9`](https://github.com/apache/spark/commit/a69b1d9f0cbbbca44b48107763efed11d31019f6).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-96411897
@chenghao-intel default SerDe found. I will update this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-96768915
[Test build #30976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30976/consoleFull) for PR 5688 at commit [`7475451`](https://github.com/apache/spark/commit/74754515236de5a6d12341972853e031df386589).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7119][SQL] ScriptTransform should also ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5688#issuecomment-95917038
[Test build #30934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30934/consoleFull) for PR 5688 at commit [`7b1a00a`](https://github.com/apache/spark/commit/7b1a00a1dc281870e8779b5153fa1fd1bc797aeb).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org