[GitHub] [arrow] jorisvandenbossche commented on pull request #12672: ARROW-15779: [Python] Create python bindings for Substrait consumer

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on PR #12672:
URL: https://github.com/apache/arrow/pull/12672#issuecomment-1130051784

   The python/cython code looks good to me.
   
   I was playing a little bit with it, and ran into the following segfault (although I suppose this is a general substrait bug and not necessarily related to this PR). 
   If I replace the FILENAME_PLACEHOLDER in the query in the tests with a nonexistent filename, I get a segfault:
   
   ```
   In [41]: query = substrait_query.replace("FILENAME_PLACEHOLDER", "/home/joris/scipy/test_wrong.arrow")
   
   In [42]: buf = pa._substrait._parse_json_plan(query.encode())
   
   In [43]: reader = substrait.run_query(buf)
   ../src/arrow/engine/substrait/util.cc:70:  Check failed: _s.ok() Operation failed: this->Close()
   Bad status: IOError: Failed to open local file '/home/joris/scipy/test_wrong.arrow'
   ../src/arrow/io/file.cc:110  ::arrow::internal::FileOpenReadable(file_name_)
   ../src/arrow/io/file.cc:320  file->impl_->Open(path)
   ../src/arrow/dataset/file_ipc.cc:70  source.Open(). Detail: [errno 2] No such file or directory
   /home/joris/miniconda3/envs/arrow-dev/lib/libarrow.so.800(+0x12c6476)[0x7faf77cd4476]
   ....
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org