You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/22 20:55:37 UTC

[GitHub] [kafka] C0urante opened a new pull request #10178: KAFKA-12361: Use default request.timeout.ms value for Connect producers

C0urante opened a new pull request #10178:
URL: https://github.com/apache/kafka/pull/10178


   [Jira](https://issues.apache.org/jira/browse/KAFKA-12361)
   
   The super-high request timeout makes it harder for the producer to gracefully handle unclean connection terminations, which might happen in the case of sudden broker death.
   
   Reducing that value to the default of 30 seconds should address that issue, without compromising the existing delivery guarantees of the Connect framework. Since the delivery timeout is still set to a very-high value, this change shouldn't make it more likely for `Producer::send` to throw an exception and fail the task.
   
   This may make duplicate record delivery more likely in cases with extremely-slow broker response time, but that can be addressed by enabling idempotence in the underlying producers for the connector's tasks.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10178: KAFKA-12361: Use default request.timeout.ms value for Connect producers

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10178:
URL: https://github.com/apache/kafka/pull/10178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10178: KAFKA-12361: Use default request.timeout.ms value for Connect producers

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10178:
URL: https://github.com/apache/kafka/pull/10178#issuecomment-783669441


   @hachikuji Does this look alright to you? The changes are trivial but I'm also hoping my summary of the situation in the description is correct and won't mislead anyone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org