You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/02/27 19:28:34 UTC

[Impala-ASF-CR] IMPALA-11952 (part 2): Fix print function syntax

Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19552 )

Change subject: IMPALA-11952 (part 2): Fix print function syntax
......................................................................

IMPALA-11952 (part 2): Fix print function syntax

Python 3 now treats print as a function and requires
the parenthesis in invocation.

print "Hello World!"
is now:
print("Hello World!")

This fixes all locations to use the function
invocation. This is more complicated when the output
is being redirected to a file or when avoiding the
usual newline.

print >> sys.stderr , "Hello World!"
is now:
print("Hello World!", file=sys.stderr)

To support this properly and guarantee equivalent behavior
between python 2 and python 3, all files that use print
now add this import:
from __future__ import print_function

Testing:
 - check-python-syntax.sh shows no errors related to print

Change-Id: Ib634958369ad777a41e72d80c8053b74384ac351
---
M be/src/codegen/gen_ir_descriptions.py
M bin/check-rat-report.py
M bin/collect_minidumps.py
M bin/compare_branches.py
M bin/diagnostics/experimental/plan-graph.py
M bin/diagnostics/experimental/tpcds_run_comparator.py
M bin/gen_build_version.py
M bin/generate_xml_config.py
M bin/get_code_size.py
M bin/inline_pom.py
M bin/jenkins/critique-gerrit-review.py
M bin/jenkins/dockerized-impala-preserve-vars.py
M bin/jenkins/populate_m2_directory.py
M bin/load-data.py
M bin/parse-thrift-profile.py
M bin/push_to_asf.py
M bin/run-workload.py
M bin/single_node_perf_run.py
M bin/validate-unified-backend-test-filters.py
M common/thrift/generate_error_codes.py
M common/thrift/generate_metrics.py
M infra/deploy/deploy.py
M lib/python/impala_py_lib/gdb/impala-gdb.py
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
M lib/python/impala_py_lib/profiles.py
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load-tpc-kudu.py
M testdata/bin/rewrite-iceberg-metadata.py
M testdata/bin/wait-for-hiveserver2.py
M testdata/bin/wait-for-metastore.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/common/cgroups.py
M testdata/common/text_delims_table.py
M testdata/common/widetable.py
M tests/benchmark/report_benchmark_results.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/resource_pool_config.py
M tests/comparison/cluster.py
M tests/comparison/data_generator_mapper.py
M tests/comparison/db_connection.py
M tests/comparison/discrepancy_searcher.py
M tests/comparison/query_generator.py
M tests/comparison/util/verify-oracle-connection.py
M tests/conftest.py
M tests/custom_cluster/test_blacklist.py
M tests/custom_cluster/test_breakpad.py
M tests/custom_cluster/test_catalog_hms_failures.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_events_custom_configs.py
M tests/custom_cluster/test_local_catalog.py
M tests/custom_cluster/test_query_retries.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_scratch_disk.py
M tests/custom_cluster/test_topic_update_frequency.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/custom_cluster/test_web_pages.py
M tests/metadata/test_hms_integration.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_kudu.py
M tests/query_test/test_limit.py
M tests/query_test/test_scanners.py
M tests/run-tests.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/statestore/test_statestore.py
M tests/stress/extract_min_mem.py
M tests/stress/runtime_info.py
M tests/unittests/test_file_parser.py
M tests/util/acid_txn.py
M tests/util/run_impyla_http_query.py
M tests/util/test_file_parser.py
75 files changed, 270 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/19552/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib634958369ad777a41e72d80c8053b74384ac351
Gerrit-Change-Number: 19552
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>