You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/03/09 18:25:24 UTC
Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
-----------------------------------------------------------
Review request for mesos, Adam B and Benjamin Bannier.
Repository: mesos
Description
-------
The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.
Diffs
-----
CHANGELOG c5eec5fcac58df2417922e4722238b9a2f321c76
include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a
Diff: https://reviews.apache.org/r/57472/diff/1/
Testing
-------
`make check`
Thanks,
Alexander Rojas
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
-----------------------------------------------------------
(Updated March 10, 2017, 10:16 a.m.)
Review request for mesos, Adam B and Benjamin Bannier.
Changes
-------
Adam's review.
Repository: mesos
Description
-------
The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.
Diffs (updated)
-----
CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252
include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413
src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67
src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
Diff: https://reviews.apache.org/r/57472/diff/3/
Changes: https://reviews.apache.org/r/57472/diff/2-3/
Testing
-------
`make check`
Thanks,
Alexander Rojas
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/57472/diff/1/?file=1660387#file1660387line6>
> >
> > Please mention this in the docs/upgrades.md table as well.
>
> Benjamin Bannier wrote:
> Did you forget to push the update fixing this?
What do you mean, it is in this patch.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
-----------------------------------------------------------
On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 10:16 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
> docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252
> include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
> src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
> src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413
> src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67
> src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
> src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
>
>
> Diff: https://reviews.apache.org/r/57472/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/57472/diff/1/?file=1660387#file1660387line6>
> >
> > Please mention this in the docs/upgrades.md table as well.
Did you forget to push the update fixing this?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
-----------------------------------------------------------
On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 10:16 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
> docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252
> include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
> src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
> src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413
> src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67
> src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
> src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
>
>
> Diff: https://reviews.apache.org/r/57472/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/57472/diff/1/?file=1660387#file1660387line6>
> >
> > Please mention this in the docs/upgrades.md table as well.
>
> Benjamin Bannier wrote:
> Did you forget to push the update fixing this?
>
> Alexander Rojas wrote:
> What do you mean, it is in this patch.
https://reviews.apache.org/r/57472/diff/3#1
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
-----------------------------------------------------------
On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 10:16 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
> docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252
> include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
> src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
> src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413
> src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67
> src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
> src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
>
>
> Diff: https://reviews.apache.org/r/57472/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
-----------------------------------------------------------
Thanks for taking this on. Besides a couple of doc updates, there's at least one more place to clean up:
https://github.com/apache/mesos/blob/1.2.0/src/master/master.hpp#L1036
```
// TODO(mpark): The following functions `authorizeSetQuota` and
// `authorizeRemoveQuota` should be replaced with `authorizeUpdateQuota` at
// the end of deprecation cycle which started with 1.0.`
```
CHANGELOG
Lines 1 (patched)
<https://reviews.apache.org/r/57472/#comment240847>
`Release Notes - Mesos - Version 1.3.0 (WIP)`
CHANGELOG
Lines 6 (patched)
<https://reviews.apache.org/r/57472/#comment240848>
Please mention this in the docs/upgrades.md table as well.
- Adam B
On March 10, 2017, 12:43 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 12:43 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
> include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
> src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
> src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
> src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
>
>
> Diff: https://reviews.apache.org/r/57472/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
-----------------------------------------------------------
(Updated March 10, 2017, 9:43 a.m.)
Review request for mesos, Adam B and Benjamin Bannier.
Changes
-------
Rebased
Repository: mesos
Description
-------
The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.
Diffs (updated)
-----
CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837
Diff: https://reviews.apache.org/r/57472/diff/2/
Changes: https://reviews.apache.org/r/57472/diff/1-2/
Testing
-------
`make check`
Thanks,
Alexander Rojas
Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and
`RemoveQuota`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
-----------------------------------------------------------
(Updated March 10, 2017, 9:18 a.m.)
Review request for mesos, Adam B and Benjamin Bannier.
Repository: mesos
Description
-------
The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.
Diffs
-----
CHANGELOG c5eec5fcac58df2417922e4722238b9a2f321c76
include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22
src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510
src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a
Diff: https://reviews.apache.org/r/57472/diff/1/
Testing
-------
`make check`
Thanks,
Alexander Rojas