You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2017/04/18 18:59:05 UTC

[GitHub] incubator-madlib pull request #117: Decision Tree: Update defaults for max_d...

GitHub user iyerr3 opened a pull request:

    https://github.com/apache/incubator-madlib/pull/117

    Decision Tree: Update defaults for max_depth, num_splits

    Reduce the defaults for max_depth to 7 and num_splits to 20 to ensure we
    don't run out of memory when initializing tree for problems with many
    features or with features with many categorical values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iyerr3/incubator-madlib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 352d0c260722980f59a9e0b1e74a0650d0436c29
Author: Rahul Iyer <ri...@apache.org>
Date:   2017-04-18T18:53:36Z

    Decision Tree: Update defaults for max_depth, num_splits
    
    Reduce the defaults for max_depth to 7 and num_splits to 20 to ensure we
    don't run out of memory when initializing tree for problems with many
    features or with features with many categorical values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by ivannovick <gi...@git.apache.org>.
Github user ivannovick commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    does this improve memory usage?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by ivannovick <gi...@git.apache.org>.
Github user ivannovick commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    How do we update the docs in synch with this change?
    https://madlib.incubator.apache.org/docs/latest/group__grp__decision__tree.html
    
    Is it needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    The docs/latest corresponds to latest release (1.10) and won't be updated till the next release. We also have [docs/master](http://madlib.incubator.apache.org/docs/master/), which can reflect these changes. We haven't updated those since the 1.10 release - I can update if you're looking for the changes reflected online. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    Ivan, the docs get updated when the release GA's.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #117: Decision Tree: Update defaults for max_d...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-madlib/pull/117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    Reading the commit description again, I would rephrase it as 
    
    "Reduce the defaults for max_depth to 7 and num_splits to 20 to **minimize
    the chances of running out of memory** when initializing tree for problems 
    with many features or with features with many categorical values."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/117
  
    No, that's a separate JIRA: MADLIB-1057
    <https://issues.apache.org/jira/browse/MADLIB-1057>. This one is just about
    setting the defaults to a more reasonable value considering the data that
    users have shared.
    
    The commit is a little more than just changing two numbers since I updated
    the way these defaults are set. Previously they were set in overloaded
    function declaration (in SQL). Changed this to set the default in the main
    function definition, eliminating redundancy.
    
    Thanks,
    Rahul



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---