[GitHub] incubator-fineract pull request #155: FINERACT-177 individual client share i...

[nazeer1100126 <gi...@git.apache.org>]

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/155#discussion_r73111971
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/GroupLoanIndividualMonitoringApiResource.java ---
    @@ -0,0 +1,119 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.fineract.portfolio.loanaccount.api;
    +
    +import java.util.Collection;
    +
    +import javax.ws.rs.Consumes;
    +import javax.ws.rs.GET;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.PathParam;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.core.Context;
    +import javax.ws.rs.core.MediaType;
    +import javax.ws.rs.core.UriInfo;
    +
    +import org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformService;
    +import org.apache.fineract.infrastructure.core.api.ApiRequestParameterHelper;
    +import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
    +import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
    +import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.context.annotation.Scope;
    +import org.springframework.stereotype.Component;
    +
    +import org.apache.fineract.portfolio.loanaccount.data.GroupLoanIndividualMonitoringData;
    +import org.apache.fineract.portfolio.loanaccount.service.GroupLoanIndividualMonitoringReadPlatformService;
    +
    +@Path("/grouploanindividualmonitoring")
    +@Component
    +@Scope("singleton")
    +public class GroupLoanIndividualMonitoringApiResource {
    +	
    +	private final PlatformSecurityContext context;
    +    private final ApiRequestParameterHelper apiRequestParameterHelper;
    +    private final DefaultToApiJsonSerializer<GroupLoanIndividualMonitoringData> toApiJsonSerializer;
    +    private final PortfolioCommandSourceWritePlatformService commandsSourceWritePlatformService;
    +    private final GroupLoanIndividualMonitoringReadPlatformService groupLoanIndividualMonitoringReadPlatformService;
    +	
    +    @Autowired
    +    public GroupLoanIndividualMonitoringApiResource(
    +			final PlatformSecurityContext context,
    +			final ApiRequestParameterHelper apiRequestParameterHelper,
    +			final DefaultToApiJsonSerializer<GroupLoanIndividualMonitoringData> toApiJsonSerializer,
    +			final PortfolioCommandSourceWritePlatformService commandsSourceWritePlatformService,
    +			final GroupLoanIndividualMonitoringReadPlatformService groupLoanIndividualMonitoringReadPlatformService) {
    +		this.context = context;
    +		this.apiRequestParameterHelper = apiRequestParameterHelper;
    +		this.toApiJsonSerializer = toApiJsonSerializer;
    +		this.commandsSourceWritePlatformService = commandsSourceWritePlatformService;
    +		this.groupLoanIndividualMonitoringReadPlatformService = groupLoanIndividualMonitoringReadPlatformService;
    +	}
    +    
    +    @GET
    +    @Consumes({ MediaType.APPLICATION_JSON })
    +    @Produces({ MediaType.APPLICATION_JSON })
    +    public String retrieveAll(@Context final UriInfo uriInfo) {
    --- End diff --
    
    Better to give pagination support. Instead of giving complete data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---