[GitHub] [netbeans] eirikbakke commented on a change in pull request #504: Option to skip CoS copying of class files when the target is already newer, such as from an external compilation

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #504:
URL: https://github.com/apache/netbeans/pull/504#discussion_r513640956



##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/usages/BuildArtifactMapperImpl.java
##########
@@ -853,8 +870,9 @@ private Boolean performUpdate(@NonNull final Context ctx) throws IOException {
                 File target = resolveFile(targetFolder, relPath);                        
 
                 try {
-                    copyFile(updatedFile, target);
-                    updatedFiles.add(target);
+                    if (copyFile(updatedFile, target, new URL(ctx.getSourceRoot(), relPath))) {
+                        updatedFiles.add(target);

Review comment:
       What's the rule for which files need to be added to updatedFiles? Who is listening for changes here? If the reason that the file was not copied is that it changed externally, is that something a listener somewhere should be notified of?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists