You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/02 07:19:53 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
jorgecarleitao opened a new pull request #8324:
URL: https://github.com/apache/arrow/pull/8324
@kszucs @nevi-me @andygrove @paddyhoran what do you think about this? (please tag others if relevant)
The idea being:
* PRs that change code in `rust/` are labeled `rust-lang`
* PRs that change code in `rust/datafusion` are labeled `datafusion`
The problems it solves:
* it is currently difficult to filter PRs by component, as we cannot bookmark a view for that filter
* It is currently difficult to find the component in the title (than it is to find on labels, due to the coloring)
* PRs may change code in `rust/` even though it is not labeled as such, and folks in Rust would probably like to know about it
Since @andygrove has been adding labels, I though that we could automatize it as an action.
I did not expand to other labels as I am not sure other parts use github labels at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702773859
@jorgecarleitao I will be very happy to relinquish my role as github label admin (as I'm sure the other Rust committers will too). Thanks for working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-703532874
> @kszucs What do you think about this file name (`dev_labelar`) ?
We organize the gha configurations based on "language" and event. Based on that we have the option to name it `dev_pull_request_target.yml` but the `pull_request_target` event name is so misleading that I'd rather keep `dev_labeler.yml` since it's much more descriptive. Once we have more actions triggered on this event we can find a better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702805572
@kou, Thanks for the suggestion. I have moved the content to another place and added the `on` accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702572374
https://issues.apache.org/jira/browse/ARROW-10156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-703042742
FYI @lidavidm (`lang-java`) and @romainfrancois (`lang-R`), since both of you are also tagging PRs with github labels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702612618
Do you want to change `on` in `dev_cron.yml`?
I don't think that it's a good idea. If we don't use `schedule`, it's not CRON.
How about creating a new workflow file such as `.github/workflows/dev_pull_request.yml` or something and putting only this job to the new workflow file?
Other existing jobs (`jira-link` and `title-check`) can be migrated to `pull_request_target` from `schedule` but we need to change `.github/workflows/dev_cron/*.js` logic. We can work on it as a follow-up task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8324:
URL: https://github.com/apache/arrow/pull/8324
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-703561673
OK.
I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702578553
I think that `dev_cron.yml` isn't suitable.
Jobs in it run periodically.
How about using `pull_request_target` instead like https://github.com/actions/labeler#create-workflow ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#discussion_r499054289
##########
File path: .github/workflows/dev_labeler.yml
##########
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+on:
+- pull_request_target
+
+jobs:
+ assign-rust-labels:
+ if: github.repository == 'apache/arrow'
+ runs-on: ubuntu-latest
+ steps:
+ - name: Assign github labels
Review comment:
```suggestion
- name: Assign GitHub labels
```
##########
File path: .github/workflows/dev_labeler.yml
##########
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+on:
+- pull_request_target
+
+jobs:
+ assign-rust-labels:
+ if: github.repository == 'apache/arrow'
Review comment:
We don't need this restriction.
We have this restriction in `dev_cron.yml` because cron GitHub Actions logs in forks hide other logs.
`pull_request_target` doesn't run this job periodically. So we don't need this restriction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702805572
@kou, Thanks for the suggestion. I have move the content to another place and added the `on` accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8324: ARROW-10156: [Rust] Added github action to label PRs for rust.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8324:
URL: https://github.com/apache/arrow/pull/8324#issuecomment-702582768
I agree @kou that `dev_cron` is not suitable atm and I though about a new flow. However, looking at the current jobs there, I think that they can all be migrated to a different `on`, since they can all be triggered by events, instead of a schedule.
So, my plan was to PR a migration of that dev_cron to be triggered by events, like you suggest. Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org