You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/24 22:41:25 UTC
[GitHub] [incubator-nuttx] patacongo commented on issue #1114: testbuild.sh: Fails if EXTRA_FLAGS not defined
patacongo commented on issue #1114:
URL: https://github.com/apache/incubator-nuttx/issues/1114#issuecomment-633311172
Perhaps something like this would do the job:
diff --git a/tools/testbuild.sh b/tools/testbuild.sh
index 91efb5354e..6895ef181e 100755
--- a/tools/testbuild.sh
+++ b/tools/testbuild.sh
@@ -89,7 +89,7 @@ while [ ! -z "$1" ]; do
;;
-e )
shift
- EXTRA_FLAGS="EXTRAFLAGS=$1"
+ EXTRA_FLAGS="EXTRAFLAGS=\"$1\""
;;
-x )
MAKE_FLAGS='--silent --no-print-directory'
@@ -158,7 +158,7 @@ blacklist=`grep "^-" $testfile || true`
cd $nuttx || { echo "ERROR: failed to CD to $nuttx"; exit 1; }
function makefunc {
- if ! ${MAKE} ${MAKE_FLAGS} "${EXTRA_FLAGS}" $@ 1>/dev/null; then
+ if ! ${MAKE} ${MAKE_FLAGS} ${EXTRA_FLAGS} $@ 1>/dev/null; then
fail=1
fi
}
The backslash will retain the " inside of the EXTRA_FLAGS string and it should be present on the command line when ${EXTRA_FLAGS} is expanded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org