You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Ben Laurie <be...@gonzo.ben.algroup.co.uk> on 1997/02/21 15:25:44 UTC

Bug in bpushfd

If bpushfd is handed -1 for file descriptors (as it is in the proxy) it notes
them for cleanup. This is, of course, wrong:

Index: buff.c
===================================================================
RCS file: /export/home/cvs/apache/src/buff.c,v
retrieving revision 1.20
diff -c -r1.20 buff.c
*** buff.c      1997/02/17 11:05:01     1.20
--- buff.c      1997/02/21 15:36:43
***************
*** 149,156 ****
  {
      fb->fd = fd_out;
      fb->fd_in = fd_in;
!     note_cleanups_for_fd(fb->pool,fb->fd);
!     if(fb->fd != fb->fd_in)
        note_cleanups_for_fd(fb->pool,fb->fd_in);
  }

--- 149,157 ----
  {
      fb->fd = fd_out;
      fb->fd_in = fd_in;
!     if(fb->fd >= 0)
!       note_cleanups_for_fd(fb->pool,fb->fd);
!     if(fb->fd != fb->fd_in && fb->fd_in >= 0)
        note_cleanups_for_fd(fb->pool,fb->fd_in);
  }

Cheers,

Ben.

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author