You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/08/10 22:54:16 UTC
[jira] Created: (LUCENE-2595) most tests should use
MockRAMDirectory not RAMDirectory
most tests should use MockRAMDirectory not RAMDirectory
-------------------------------------------------------
Key: LUCENE-2595
URL: https://issues.apache.org/jira/browse/LUCENE-2595
Project: Lucene - Java
Issue Type: Test
Reporter: Robert Muir
Fix For: 3.1, 4.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2595) most tests should use
MockRAMDirectory not RAMDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897058#action_12897058 ]
Robert Muir commented on LUCENE-2595:
-------------------------------------
Committed revision 984232. I'll backport LUCENE-2594 to 3x first.
> most tests should use MockRAMDirectory not RAMDirectory
> -------------------------------------------------------
>
> Key: LUCENE-2595
> URL: https://issues.apache.org/jira/browse/LUCENE-2595
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2595.patch, LUCENE-2595.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2595) most tests should use
MockRAMDirectory not RAMDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2595.
---------------------------------
Resolution: Fixed
Committed revision 984299 to 3x
> most tests should use MockRAMDirectory not RAMDirectory
> -------------------------------------------------------
>
> Key: LUCENE-2595
> URL: https://issues.apache.org/jira/browse/LUCENE-2595
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2595.patch, LUCENE-2595.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2595) most tests should use
MockRAMDirectory not RAMDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2595:
--------------------------------
Attachment: LUCENE-2595.patch
updated patch: all tests pass.
I did add one TODO to investigate in TestIW:
{code}
public void testCommitOnCloseOptimize() throws IOException {
MockRAMDirectory dir = new MockRAMDirectory();
dir.setPreventDoubleWrite(false); // TODO: should this be disabled here?
{code}
> most tests should use MockRAMDirectory not RAMDirectory
> -------------------------------------------------------
>
> Key: LUCENE-2595
> URL: https://issues.apache.org/jira/browse/LUCENE-2595
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2595.patch, LUCENE-2595.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2595) most tests should use
MockRAMDirectory not RAMDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2595:
--------------------------------
Attachment: LUCENE-2595.patch
heres a patch switching tests over (some fail, i didnt even look at resolving these yet).
I think once we fix this, we can look at moving the test system where it tests a variety of directory impls and supports something like -Dtests.directoryImpl= or something like that to run all the tests against a specific impl.
> most tests should use MockRAMDirectory not RAMDirectory
> -------------------------------------------------------
>
> Key: LUCENE-2595
> URL: https://issues.apache.org/jira/browse/LUCENE-2595
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2595.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org