You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/08 15:59:43 UTC
[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request
#3380: Add SSL Certificate Validation to Traffic Router
ajschmidt commented on a change in pull request #3380: Add SSL Certificate Validation to Traffic Router
URL: https://github.com/apache/trafficcontrol/pull/3380#discussion_r263829637
##########
File path: infrastructure/docker/traffic_router/Dockerfile
##########
@@ -35,6 +35,8 @@ ARG TC_REPO=traffic-control.repo
ADD $TMCAT /
ADD $RPM /
ADD $TC_REPO /etc/yum.repos.d/
+ADD starttr.sh /
+ADD shutdowntr.sh /
Review comment:
systemd has been disabled in the centos 7 docker container so we can no longer use the unit files to start/stop processes. The starttr.sh gets called by the run.sh, and yes, I do `docker exec` to run the shutdown. I also copy in new TR rpms so I can test code changes without having to rebuild the whole Docker image. We have done something similar in CIAB for the TR and ATS containers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services