[jira] [Commented] (BEAM-10051) Misordered check WRT closed data readers.

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191800#comment-17191800 ] 

Beam JIRA Bot commented on BEAM-10051:
--------------------------------------

This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3.

Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean.


> Misordered check WRT closed data readers.
> -----------------------------------------
>
>                 Key: BEAM-10051
>                 URL: https://issues.apache.org/jira/browse/BEAM-10051
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P2
>              Labels: stale-P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This check https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L269
> in it's current position prevents the "normal teardown" that the reader expects. This means that readers for instructions that terminate early such as due to splitting stay resident in memory and never close.
> In practice this is benign as the buffer would already be closed, but with streaming this  memory leak would become noticable.
> The fix is to move the check to after the sentinel check, and additionally check there for early termination to avoid closing the buffer twice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)