You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/23 11:31:11 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #4811: [HUDI-3213] Making commit preserve metadata to true for compaction

nsivabalan commented on a change in pull request #4811:
URL: https://github.com/apache/hudi/pull/4811#discussion_r812798456



##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -373,10 +373,36 @@ public static GenericRecord rewriteRecord(GenericRecord oldRecord, Schema newSch
     return newRecord;
   }
 
+  public static GenericRecord rewriteRecord(GenericRecord genericRecord, Schema newSchema, boolean copyOverMetaFields, GenericRecord oldRecord) {

Review comment:
       may be we can name the last arg as "fallbackRecord".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org