[GitHub] [incubator-inlong] charlely commented on a change in pull request #1578: [INLONG-1570]Provide a more elegant way to set the parameter of config

[GitBox <gi...@apache.org>]

charlely commented on a change in pull request #1578:
URL: https://github.com/apache/incubator-inlong/pull/1578#discussion_r713554569



##########
File path: tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -744,3 +752,15 @@ func (c *consumer) closeAllBrokers() {
 	}
 	log.Infof("[CONSUMER] closeAllBrokers end, client=%s", c.clientID)
 }
+
+// Invoke implementation of TubeMQ consumer.
+func (c *consumer) Invoke(config *config.Config, opts ...config.Option) (Consumer, error) {

Review comment:
       Maybe you can use  NewConfig(opts ..config.Option) *config.Config is a good idea.
   And use NewConsumer(config *config.Config) to start.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org