You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "David Leangen (JIRA)" <ji...@apache.org> on 2008/07/01 02:12:45 UTC
[jira] Created: (WICKET-1722) Use path in URL when target is
instance of BookmarkablePageRequestTarget
Use path in URL when target is instance of BookmarkablePageRequestTarget
------------------------------------------------------------------------
Key: WICKET-1722
URL: https://issues.apache.org/jira/browse/WICKET-1722
Project: Wicket
Issue Type: Improvement
Reporter: David Leangen
Priority: Minor
As described here:
http://www.nabble.com/-PROPOSAL--Use-path-in-URL-when-target-is-instance-of-BookmarkablePageRequestTarget-tt18188845.html#a18188845
Currently, when a target is an instance of IListenerInterfaceRequestTarget, the URL gets "mounted" (so to speak) on the root of where the wicket application is located.
So, if the servlet context path for the wicket application is set to /home/, then all targets (whether bookmarkable or not), are written as something like /home/?wicket:interface=:0::::.
This works, but I think it somewhat defeats the purpose of having mounted pages.
Rather, I think it would be better that when the target is an instance of BookmarkablePageRequestTarget, since we can get the target path easily, we should therefore write the URL to that target path, and not the application's root path.
So, if I have a form on a page mounted at /home/myform, the above link gets rendered as /home/myform/?wicket:interface=:0:::: instead.
The fix is quite simple and it appears to work without any problems. Will attach patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1722) Use path in URL when target is
instance of BookmarkablePageRequestTarget
Posted by "David Leangen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Leangen updated WICKET-1722:
----------------------------------
Attachment: WebRequestCodingStrategy-1.3.diff
Hmmm... current trunk is too different for me to use at this time. The patch is for the 1.3 branch.
Later when I get the time, and if it's still needed, I'll look into making a patch for trunk.
> Use path in URL when target is instance of BookmarkablePageRequestTarget
> ------------------------------------------------------------------------
>
> Key: WICKET-1722
> URL: https://issues.apache.org/jira/browse/WICKET-1722
> Project: Wicket
> Issue Type: Improvement
> Reporter: David Leangen
> Priority: Minor
> Attachments: WebRequestCodingStrategy-1.3.diff
>
>
> As described here:
> http://www.nabble.com/-PROPOSAL--Use-path-in-URL-when-target-is-instance-of-BookmarkablePageRequestTarget-tt18188845.html#a18188845
> Currently, when a target is an instance of IListenerInterfaceRequestTarget, the URL gets "mounted" (so to speak) on the root of where the wicket application is located.
> So, if the servlet context path for the wicket application is set to /home/, then all targets (whether bookmarkable or not), are written as something like /home/?wicket:interface=:0::::.
> This works, but I think it somewhat defeats the purpose of having mounted pages.
> Rather, I think it would be better that when the target is an instance of BookmarkablePageRequestTarget, since we can get the target path easily, we should therefore write the URL to that target path, and not the application's root path.
> So, if I have a form on a page mounted at /home/myform, the above link gets rendered as /home/myform/?wicket:interface=:0:::: instead.
> The fix is quite simple and it appears to work without any problems. Will attach patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.