[GitHub] [fineract] adamsaghy opened a new pull request, #2700: FINERACT-1784: Support undo waive charge for specific due date charges

[GitBox <gi...@apache.org>]

adamsaghy opened a new pull request, #2700:
URL: https://github.com/apache/fineract/pull/2700

   ## Description
   
   Support undoing(reversing) a "waive charge" transaction for specified due date charge.
   
   **Fixed**:
   - missing repayment schedule recalculation
   - missing loan summary recalculation
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics merged pull request #2700: FINERACT-1784: Support undo waive charge for specific due date charges

[GitBox <gi...@apache.org>]

galovics merged PR #2700:
URL: https://github.com/apache/fineract/pull/2700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on a diff in pull request #2700: FINERACT-1784: Support undo waive charge for specific due date charges

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2700:
URL: https://github.com/apache/fineract/pull/2700#discussion_r1004841171


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerStopListener.java:
##########
@@ -41,13 +37,17 @@ public class SchedulerStopListener implements JobListener {
 
     private JobRegisterService jobRegisterService;
 
+    public void setJobRegisterService(JobRegisterService jobRegisterService) {

Review Comment:
   I guess this was more of a testing and not needed (as far as I can tell from the instantiation of this class)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org