You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/08/15 03:48:13 UTC
[PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
kevinjqliu opened a new pull request, #13825:
URL: https://github.com/apache/iceberg/pull/13825
Closes #13818
This PR adds support for passing Microsoft Entra access token to `ADLSFileIO` using the new `ADLS_TOKEN` property.
The [TokenCredential](https://learn.microsoft.com/en-us/java/api/com.azure.core.credential.tokencredential?view=azure-java-stable) is then used to configure the [DataLakeFileSystemClientBuilder](https://learn.microsoft.com/en-us/java/api/com.azure.storage.file.datalake.datalakefilesystemclientbuilder?view=azure-java-stable#com-azure-storage-file-datalake-datalakefilesystemclientbuilder-credential(com-azure-core-credential-tokencredential)).
See a [similar implementation in apache doris](https://github.com/apache/doris/blob/a6343d75527758434e0c37026c8948b83cfcdc7e/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/AzureRemote.java#L238-L254)
The token expiration is set for 1 hour for now, which is the [default lifetime of an access token](https://learn.microsoft.com/en-us/entra/identity-platform/access-tokens?utm_source=chatgpt.com#token-lifetime). We can make this configurable in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #13825:
URL: https://github.com/apache/iceberg/pull/13825#issuecomment-3195464314
@kevinjqliu: Could we add a test case for the new feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #13825:
URL: https://github.com/apache/iceberg/pull/13825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #13825:
URL: https://github.com/apache/iceberg/pull/13825#issuecomment-3199417503
Merged to main.
Thanks for the PR @kevinjqliu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13825:
URL: https://github.com/apache/iceberg/pull/13825#issuecomment-3192012075
cc @bryanck @mrcnc @NikitaMatskevich since yall have experience working with ADLSFileIO :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ADLSFileIO: support access token authentication via the new `adls.token` property [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13825:
URL: https://github.com/apache/iceberg/pull/13825#issuecomment-3199161607
@pvary added! could you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org