You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/09 06:06:56 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #14961: [Bug](predicate) fix undefined behavior on in list predicate
BiteTheDDDDt opened a new pull request, #14961:
URL: https://github.com/apache/doris/pull/14961
# Proposed changes
```cpp
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mnt/disk1/yuejing/projects/doris/be/src/exprs/hybrid_set.h:145:62 in
Current BE git commitID: b3b493fde ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk1/yuejing/projects/doris/be/src/common/signal_handler.h:420
1# os::Linux::chained_handler(int, siginfo*, void*) in /mnt/disk1/yuejing/downloads/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
2# JVM_handle_linux_signal in /mnt/disk1/yuejing/downloads/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
3# signalHandler(int, siginfo*, void*) in /mnt/disk1/yuejing/downloads/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
4# 0x00007FA2BC34A400 in /lib64/libc.so.6
5# doris::DateTimeValue::to_olap_date() const at /mnt/disk1/yuejing/projects/doris/be/src/runtime/datetime_value.h:239
6# doris::InListPredicateBase<(doris::PrimitiveType)11, (doris::PredicateType)7>::InListPredicateBase(unsigned int, std::shared_ptr<doris::HybridSetBase> const&, unsigned long) a
t /mnt/disk1/yuejing/projects/doris/be/src/olap/in_list_predicate.h:142
7# doris::ColumnPredicate* doris::create_olap_column_predicate<(doris::PrimitiveType)11>(unsigned int, std::shared_ptr<doris::HybridSetBase> const&, int, doris::TabletColumn cons
t*) at /mnt/disk1/yuejing/projects/doris/be/src/exprs/create_predicate_function.h:192
8# doris::ColumnPredicate* doris::create_column_predicate<doris::HybridSetBase>(unsigned int, std::shared_ptr<doris::HybridSetBase> const&, doris::FieldType, int, doris::TabletCo
lumn const*) at /mnt/disk1/yuejing/projects/doris/be/src/exprs/create_predicate_function.h:205
9# doris::TabletReader::parse_to_predicate(std::pair<std::_cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::shared_ptr<doris::HybridSetBase> > con
st&) at /mnt/disk1/yuejing/projects/doris/be/src/olap/reader.cpp:488
10# doris::TabletReader::_init_conditions_param(doris::TabletReader::ReaderParams const&) at /mnt/disk1/yuejing/projects/doris/be/src/olap/reader.cpp:461
11# doris::TabletReader::_init_params(doris::TabletReader::ReaderParams const&) at /mnt/disk1/yuejing/projects/doris/be/src/olap/reader.cpp:235
12# doris::TabletReader::init(doris::TabletReader::ReaderParams const&) at /mnt/disk1/yuejing/projects/doris/be/src/olap/reader.cpp:92
13# doris::vectorized::BlockReader::init(doris::TabletReader::ReaderParams const&) at /mnt/disk1/yuejing/projects/doris/be/src/vec/olap/block_reader.cpp:109
14# doris::vectorized::NewOlapScanner::open(doris::RuntimeState*) at /mnt/disk1/yuejing/projects/doris/be/src/vec/exec/scan/new_olap_scanner.cpp:118
15# doris::vectorized::ScannerScheduler::_scanner_scan(doris::vectorized::ScannerScheduler*, doris::vectorized::ScannerContext*, doris::vectorized::VScanner*) at /mnt/disk1/yuejin
g/projects/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:194
16# doris::vectorized::ScannerScheduler::_schedule_scanners(doris::vectorized::ScannerContext*)::$_1::operator()() const at /mnt/disk1/yuejing/projects/doris/be/src/vec/exec/scan/
scanner_scheduler.cpp:143
17# void std::_invoke_impl<void, doris::vectorized::ScannerScheduler::_schedule_scanners(doris::vectorized::ScannerContext*)::$_1&>(std::_invoke_other, doris::vectorized::Scanne
rScheduler::_schedule_scanners(doris::vectorized::ScannerContext*)::$_1&) at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/1
1/bits/invoke.h:61
18# std::enable_if<is_invocable_r_v<void, doris::vectorized::ScannerScheduler::schedule_scanners(doris::vectorized::ScannerContext*)::$_1&>, void>::type std::_invoke_r<void, dor
is::vectorized::ScannerScheduler::_schedule_scanners(doris::vectorized::ScannerContext*)::$_1&>(doris::vectorized::ScannerScheduler::_schedule_scanners(doris::vectorized::ScannerC
ontext*)::$_1&) at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:117
19# std::_Function_handler<void (), doris::vectorized::ScannerScheduler::_schedule_scanners(doris::vectorized::ScannerContext*)::$_1>::_M_invoke(std::_Any_data const&) at /mnt/dis
k1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
20# std::function<void ()>::operator()() const at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560
21# doris::FunctionRunnable::run() at /mnt/disk1/yuejing/projects/doris/be/src/util/threadpool.cpp:45
22# doris::ThreadPool::dispatch_thread() at /mnt/disk1/yuejing/projects/doris/be/src/util/threadpool.cpp:534
23# void std::_invoke_impl<void, void (doris::ThreadPool::&)(), doris::ThreadPool&>(std::_invoke_memfun_deref, void (doris::ThreadPool::&)(), doris::ThreadPool&) at /mnt/dis
k1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:74
24# std::_invoke_result<void (doris::ThreadPool::&)(), doris::ThreadPool&>::type std::_invoke<void (doris::ThreadPool::&)(), doris::ThreadPool&>(void (doris::ThreadPool::*&)
(), doris::ThreadPool*&) at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96
25# void std::Bind<void (doris::ThreadPool::(doris::ThreadPool))()>::_call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) at /mnt/disk1/yuejing/projects/ldb_toolchain/bi
n/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:420
26# void std::_Bind<void (doris::ThreadPool::(doris::ThreadPool))()>::operator()<, void>() at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../
../../include/c++/11/functional:503
27# void std::_invoke_impl<void, std::_Bind<void (doris::ThreadPool::(doris::ThreadPool))()>&>(std::_invoke_other, std::_Bind<void (doris::ThreadPool::(doris::ThreadPool))()
>&) at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
28# std::enable_if<is_invocable_r_v<void, std::Bind<void (doris::ThreadPool::(doris::ThreadPool))()>&>, void>::type std::_invoke_r<void, std::_Bind<void (doris::ThreadPool::*(
doris::ThreadPool*))()>&>(std::_Bind<void (doris::ThreadPool::(doris::ThreadPool))()>&) at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../
../include/c++/11/bits/invoke.h:117
29# std::_Function_handler<void (), std::_Bind<void (doris::ThreadPool::(doris::ThreadPool))()> >::_M_invoke(std::_Any_data const&) at /mnt/disk1/yuejing/projects/ldb_toolchain/
bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
30# std::function<void ()>::operator()() const at /mnt/disk1/yuejing/projects/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560
31# doris::Thread::supervise_thread(void*) at /mnt/disk1/yuejing/projects/doris/be/src/util/thread.cpp:454
32# start_thread in /lib64/libpthread.so.0
33# _GI__clone in /lib64/libc.so.6
```
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14961: [Bug](predicate) fix undefined behavior on in list predicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14961:
URL: https://github.com/apache/doris/pull/14961#issuecomment-1343894542
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14961: [Bug](predicate) fix undefined behavior on in list predicate
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14961:
URL: https://github.com/apache/doris/pull/14961#issuecomment-1343942880
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.14 seconds
load time: 481 seconds
storage size: 17123356366 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209071625_clickbench_pr_60838.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14961: [Bug](predicate) fix undefined behavior on in list predicate
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14961:
URL: https://github.com/apache/doris/pull/14961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14961: [Bug](predicate) fix undefined behavior on in list predicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14961:
URL: https://github.com/apache/doris/pull/14961#issuecomment-1344059106
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14961: [Bug](predicate) fix undefined behavior on in list predicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14961:
URL: https://github.com/apache/doris/pull/14961#issuecomment-1344059150
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org