You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/09/08 16:28:11 UTC
Review Request 62189: GEODE-2817: consolidate authorize(*) methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62189/
-----------------------------------------------------------
Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-2817: consolidate authorize(*) methods
* this is just a changeset that removed those authorizeCluster*, authorizeData* authorizeRegion* functions. They made the interface unnecessaily large, and doesn't really offer much value. I prefer to see authorize(DATA, READ, regionname), insteadof authorizeRegionRead(*) in the code so that it's clear what exactly is the permssion needed. This also makes the further change/update to the interface easier to manage.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/execute/Function.java 25ba4e37f579e1f222439ef19c223111faabda61
geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 0b4e7f9de38b234742a427b55ceda2e63d93d83e
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java f895b964794f99127f1f0c9564f3f85213e0af22
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 184aa36fc5509285001155e20d846cc717544d2f
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java 610af436cd96b0663d69915d8a1b37549e4f7bc2
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java d7a1b2b0183405142d524c1d91433eb01ac3e9f6
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java 03e798c579e6c26e3aa7cb9a522f8af514f60ce3
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java 2be4724bc2b2b6d472558cdecddba982da032a08
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java cdbab8047558234bd25aa6155a7603a62d697d03
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java c8b794a9b0b4c223e6391a8e7f63aa0747943417
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java baa2f3f480ce4bea522ea520e86328384cfd2d23
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java 08f02642e937abf3b0e2557cd06c8264ac0dee32
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java 53db561963d7b9abbe86e0dbf7e73613f6a5ceef
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java a3b061f761a9f1e6a7302b5e8dc31e9a98a9959c
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java 73eff40c34f6fe882ec1e21168e522ae9ced2736
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java 47684aa2fb5d8ec0190f0e047a627c08e77598f1
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java 26d5d3f31a6b0cf2e2ff1477a2e5e3449fd5453d
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java 8c3bb381fe6e2e9018aaf8c333a3ab0c26127c27
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java 62644eb109f661a00c2c4df06e96c8d7a4f8d33f
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java e214ce16e4be1f044f40f44308435eec43d1c8ca
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java aacfc6dccd6385ac39a9c2b65ecf6f7456bba704
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java 0449447e3b9e8bd202ed7d14f35d258034f4c861
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java 9f970a59961c8d10c498f8db6f8cb403036d9f96
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java 3952b0f98965c3a56d1c003454c323a55f295f0b
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java 202d91fc8bbfcd012a7b6c344b3ef39f63b7b81d
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java 27f8cc564c163a2d1c8448f0c7acb411993e5fc1
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java 60870d7eb04067b3ff5540597c403b9a9b491c65
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java 8f65b9bd0bdaef161d230fd1ecf47b7efa1be8cf
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java f8cd57fdfc6cd8aa939d314e94d3c1f38fe90521
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java 1bf4955021104986b7c6ac5bc9e6fa1b1085b83b
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java 3a8f0db633384f5cdb65405c3bf21d53bed30a0e
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java a1cf93f15733da95e9b1aea8b709b5d4166b8559
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java 111f234130ae4e0733d634714765ebe3c998b49e
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java c64bc6979da6049c901b34d8aaf0d66a1d26336a
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java 82e2f0d7ab79e87bec81da29610016ea8f5eafe6
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java 5f6ab9b08fa0873b8dbc7fcd755b1857ffe3770e
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java 2daf755ab200d84f0b7760224060439d9e3518f1
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java 25badd328a5d7edafb81fd3402ebcc47301983d1
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java e4485b469858881486a588adc627181d093c9949
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java 1af283bbfefee7ff4f855429139aae20076c2d78
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java 035a953fd40d90e5c49f7c53bb997637d3d24c61
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java da8a4662089d14e485377a51af9eed88917fd2d8
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 0fdb57db0f630a4ce44c81381bf6f02a0d4fb765
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommand.java 0f9b5d89773ba946a296e85929b8d8b8b7ea2bd7
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java 40bd0f334a19ef38f7465fd40916c286f92cb1ce
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GetCommand.java f09174e08527cbcfe397c30a6206a21dd7c96bfb
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ImportDataCommand.java 23084059dc19f1e5da83b319cf8f458bcc230e86
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LocateEntryCommand.java f4caf139283ead6878b4ffa20e56ac309e9e9749
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PutCommand.java 3571f6de1379dfeecdcb73a6804f763f67f35894
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java 3c039b3a70cf7b38b4f4af77079f0b5d6a39caf5
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java 12be62e856f78a3489f361278e9461d445e56905
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 1d028524ecd6c737fb53f54dcf5c6d5187f15477
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java 0492997533b88bbb73dc7e87d1f641b98f53f684
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 00420ccf341246ca740c3be0b7ab062fb70ecaaf
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java 729c68b1bf5d2a0e2b8fc634dbf42c989a68eb40
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java bf699be52da630207b542c542aa33ae9798e4000
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 59958905160ff96fc06a16423c3fb9f801c5b324
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java c53b0382732a29e64b403e8eb0f914e19de79b84
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java b2e30f264a76e88e397488609edef135b4a115c2
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java cfb496069ca95abc67dc6fe84e6eb2f430c09f2c
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 78097d2f8d8d5a67ea7fae57d9147e37fc905d25
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java 40bfe45396017b9a18a38db5eed2d3eed2fbe0f2
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java a3ee2c8b808e0d4906d89d0eec4e8ab249a3f642
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java ceb8882954e2ad0d1a638e96945976726e728b06
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java 4497c7fd48349f288f7a4a99ea283aba9f352f91
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 08e1a29ba4718c936fd953bee87c071a353ce1a1
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java a4da48f8bc5504df9323be809b1e1145947a9cd7
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java bd99e6c261f5c44a74dfc7d8b70e414a29502ed0
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 8d52b8853994e7c2788a3a90de6be3f516358606
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java 6f894cf8c9afad5f8f61df40e31ff8a23e5f3596
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java 5437f71a3de19bdc74501e5bd0939a6e4cb52ddd
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java 0ed27a0244c97ea99e1d2e7c54e91fc80b0eeff1
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java bae07b456d9d12bc9d4d10ea0af03e63248f6e2b
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java 1074de585dda9963208a20ac8d28c06a8be5d614
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java cd07e71ee7fed541473596067ad7eb636bc17637
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java de5a4597cd609d20afdc86fa3adae72d2dae1f50
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java bf7badb0fb3d2f5fae87013e1fac9dc4a5e25df2
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 50fb9cd18d45e82a7f04e61aa8dbdbf2b6b3a419
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java a37263f11cefbe317d2a24989256d7d5559cf599
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java 1ba5fed2020652b8da58c652640c97cbfcf9dd9f
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java f5e31df988f5955d2fbeef5269a7729ec97c9d03
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 41c89235dbb6b85f4ab69511ad4dba46262a5cf3
Diff: https://reviews.apache.org/r/62189/diff/1/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Sept. 8, 2017, 10:32 p.m., Ken Howe wrote:
> > geode-core/src/main/java/org/apache/geode/cache/execute/Function.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/62189/diff/1/?file=1818427#file1818427line125>
> >
> > You are expecting an internal object to be passed in a public API here.
> >
> > I think this can be deleted from the current change set as in my search it doesn't appear to be used.
Oh, yeah, this is an accidental inclusion. Will delete it.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62189/#review185028
-----------------------------------------------------------
On Sept. 8, 2017, 4:28 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62189/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 4:28 p.m.)
>
>
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2817: consolidate authorize(*) methods
>
> * this is just a changeset that removed those authorizeCluster*, authorizeData* authorizeRegion* functions. They made the interface unnecessaily large, and doesn't really offer much value. I prefer to see authorize(DATA, READ, regionname), insteadof authorizeRegionRead(*) in the code so that it's clear what exactly is the permssion needed. This also makes the further change/update to the interface easier to manage.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/execute/Function.java 25ba4e37f579e1f222439ef19c223111faabda61
> geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 0b4e7f9de38b234742a427b55ceda2e63d93d83e
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java f895b964794f99127f1f0c9564f3f85213e0af22
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 184aa36fc5509285001155e20d846cc717544d2f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java 610af436cd96b0663d69915d8a1b37549e4f7bc2
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java d7a1b2b0183405142d524c1d91433eb01ac3e9f6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java 03e798c579e6c26e3aa7cb9a522f8af514f60ce3
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java 2be4724bc2b2b6d472558cdecddba982da032a08
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java cdbab8047558234bd25aa6155a7603a62d697d03
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java c8b794a9b0b4c223e6391a8e7f63aa0747943417
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java baa2f3f480ce4bea522ea520e86328384cfd2d23
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java 08f02642e937abf3b0e2557cd06c8264ac0dee32
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java 53db561963d7b9abbe86e0dbf7e73613f6a5ceef
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java a3b061f761a9f1e6a7302b5e8dc31e9a98a9959c
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java 73eff40c34f6fe882ec1e21168e522ae9ced2736
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java 47684aa2fb5d8ec0190f0e047a627c08e77598f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java 26d5d3f31a6b0cf2e2ff1477a2e5e3449fd5453d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java 8c3bb381fe6e2e9018aaf8c333a3ab0c26127c27
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java 62644eb109f661a00c2c4df06e96c8d7a4f8d33f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java e214ce16e4be1f044f40f44308435eec43d1c8ca
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java aacfc6dccd6385ac39a9c2b65ecf6f7456bba704
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java 0449447e3b9e8bd202ed7d14f35d258034f4c861
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java 9f970a59961c8d10c498f8db6f8cb403036d9f96
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java 3952b0f98965c3a56d1c003454c323a55f295f0b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java 202d91fc8bbfcd012a7b6c344b3ef39f63b7b81d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java 27f8cc564c163a2d1c8448f0c7acb411993e5fc1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java 60870d7eb04067b3ff5540597c403b9a9b491c65
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java 8f65b9bd0bdaef161d230fd1ecf47b7efa1be8cf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java f8cd57fdfc6cd8aa939d314e94d3c1f38fe90521
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java 1bf4955021104986b7c6ac5bc9e6fa1b1085b83b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java 3a8f0db633384f5cdb65405c3bf21d53bed30a0e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java a1cf93f15733da95e9b1aea8b709b5d4166b8559
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java 111f234130ae4e0733d634714765ebe3c998b49e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java c64bc6979da6049c901b34d8aaf0d66a1d26336a
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java 82e2f0d7ab79e87bec81da29610016ea8f5eafe6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java 5f6ab9b08fa0873b8dbc7fcd755b1857ffe3770e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java 2daf755ab200d84f0b7760224060439d9e3518f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java 25badd328a5d7edafb81fd3402ebcc47301983d1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java e4485b469858881486a588adc627181d093c9949
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java 1af283bbfefee7ff4f855429139aae20076c2d78
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java 035a953fd40d90e5c49f7c53bb997637d3d24c61
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java da8a4662089d14e485377a51af9eed88917fd2d8
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 0fdb57db0f630a4ce44c81381bf6f02a0d4fb765
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommand.java 0f9b5d89773ba946a296e85929b8d8b8b7ea2bd7
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java 40bd0f334a19ef38f7465fd40916c286f92cb1ce
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GetCommand.java f09174e08527cbcfe397c30a6206a21dd7c96bfb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ImportDataCommand.java 23084059dc19f1e5da83b319cf8f458bcc230e86
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LocateEntryCommand.java f4caf139283ead6878b4ffa20e56ac309e9e9749
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PutCommand.java 3571f6de1379dfeecdcb73a6804f763f67f35894
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java 3c039b3a70cf7b38b4f4af77079f0b5d6a39caf5
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java 12be62e856f78a3489f361278e9461d445e56905
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 1d028524ecd6c737fb53f54dcf5c6d5187f15477
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java 0492997533b88bbb73dc7e87d1f641b98f53f684
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 00420ccf341246ca740c3be0b7ab062fb70ecaaf
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java 729c68b1bf5d2a0e2b8fc634dbf42c989a68eb40
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java bf699be52da630207b542c542aa33ae9798e4000
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 59958905160ff96fc06a16423c3fb9f801c5b324
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java c53b0382732a29e64b403e8eb0f914e19de79b84
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java b2e30f264a76e88e397488609edef135b4a115c2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java cfb496069ca95abc67dc6fe84e6eb2f430c09f2c
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 78097d2f8d8d5a67ea7fae57d9147e37fc905d25
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java 40bfe45396017b9a18a38db5eed2d3eed2fbe0f2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java a3ee2c8b808e0d4906d89d0eec4e8ab249a3f642
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java ceb8882954e2ad0d1a638e96945976726e728b06
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java 4497c7fd48349f288f7a4a99ea283aba9f352f91
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 08e1a29ba4718c936fd953bee87c071a353ce1a1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java a4da48f8bc5504df9323be809b1e1145947a9cd7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java bd99e6c261f5c44a74dfc7d8b70e414a29502ed0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 8d52b8853994e7c2788a3a90de6be3f516358606
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java 6f894cf8c9afad5f8f61df40e31ff8a23e5f3596
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java 5437f71a3de19bdc74501e5bd0939a6e4cb52ddd
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java 0ed27a0244c97ea99e1d2e7c54e91fc80b0eeff1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java bae07b456d9d12bc9d4d10ea0af03e63248f6e2b
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java 1074de585dda9963208a20ac8d28c06a8be5d614
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java cd07e71ee7fed541473596067ad7eb636bc17637
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java de5a4597cd609d20afdc86fa3adae72d2dae1f50
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java bf7badb0fb3d2f5fae87013e1fac9dc4a5e25df2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 50fb9cd18d45e82a7f04e61aa8dbdbf2b6b3a419
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java a37263f11cefbe317d2a24989256d7d5559cf599
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java 1ba5fed2020652b8da58c652640c97cbfcf9dd9f
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java f5e31df988f5955d2fbeef5269a7729ec97c9d03
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 41c89235dbb6b85f4ab69511ad4dba46262a5cf3
>
>
> Diff: https://reviews.apache.org/r/62189/diff/1/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62189/#review185028
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/execute/Function.java
Lines 120 (patched)
<https://reviews.apache.org/r/62189/#comment261259>
You are expecting an internal object to be passed in a public API here.
I think this can be deleted from the current change set as in my search it doesn't appear to be used.
- Ken Howe
On Sept. 8, 2017, 4:28 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62189/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 4:28 p.m.)
>
>
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2817: consolidate authorize(*) methods
>
> * this is just a changeset that removed those authorizeCluster*, authorizeData* authorizeRegion* functions. They made the interface unnecessaily large, and doesn't really offer much value. I prefer to see authorize(DATA, READ, regionname), insteadof authorizeRegionRead(*) in the code so that it's clear what exactly is the permssion needed. This also makes the further change/update to the interface easier to manage.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/execute/Function.java 25ba4e37f579e1f222439ef19c223111faabda61
> geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 0b4e7f9de38b234742a427b55ceda2e63d93d83e
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java f895b964794f99127f1f0c9564f3f85213e0af22
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 184aa36fc5509285001155e20d846cc717544d2f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java 610af436cd96b0663d69915d8a1b37549e4f7bc2
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java d7a1b2b0183405142d524c1d91433eb01ac3e9f6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java 03e798c579e6c26e3aa7cb9a522f8af514f60ce3
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java 2be4724bc2b2b6d472558cdecddba982da032a08
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java cdbab8047558234bd25aa6155a7603a62d697d03
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java c8b794a9b0b4c223e6391a8e7f63aa0747943417
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java baa2f3f480ce4bea522ea520e86328384cfd2d23
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java 08f02642e937abf3b0e2557cd06c8264ac0dee32
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java 53db561963d7b9abbe86e0dbf7e73613f6a5ceef
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java a3b061f761a9f1e6a7302b5e8dc31e9a98a9959c
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java 73eff40c34f6fe882ec1e21168e522ae9ced2736
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java 47684aa2fb5d8ec0190f0e047a627c08e77598f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java 26d5d3f31a6b0cf2e2ff1477a2e5e3449fd5453d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java 8c3bb381fe6e2e9018aaf8c333a3ab0c26127c27
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java 62644eb109f661a00c2c4df06e96c8d7a4f8d33f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java e214ce16e4be1f044f40f44308435eec43d1c8ca
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java aacfc6dccd6385ac39a9c2b65ecf6f7456bba704
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java 0449447e3b9e8bd202ed7d14f35d258034f4c861
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java 9f970a59961c8d10c498f8db6f8cb403036d9f96
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java 3952b0f98965c3a56d1c003454c323a55f295f0b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java 202d91fc8bbfcd012a7b6c344b3ef39f63b7b81d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java 27f8cc564c163a2d1c8448f0c7acb411993e5fc1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java 60870d7eb04067b3ff5540597c403b9a9b491c65
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java 8f65b9bd0bdaef161d230fd1ecf47b7efa1be8cf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java f8cd57fdfc6cd8aa939d314e94d3c1f38fe90521
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java 1bf4955021104986b7c6ac5bc9e6fa1b1085b83b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java 3a8f0db633384f5cdb65405c3bf21d53bed30a0e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java a1cf93f15733da95e9b1aea8b709b5d4166b8559
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java 111f234130ae4e0733d634714765ebe3c998b49e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java c64bc6979da6049c901b34d8aaf0d66a1d26336a
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java 82e2f0d7ab79e87bec81da29610016ea8f5eafe6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java 5f6ab9b08fa0873b8dbc7fcd755b1857ffe3770e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java 2daf755ab200d84f0b7760224060439d9e3518f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java 25badd328a5d7edafb81fd3402ebcc47301983d1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java e4485b469858881486a588adc627181d093c9949
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java 1af283bbfefee7ff4f855429139aae20076c2d78
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java 035a953fd40d90e5c49f7c53bb997637d3d24c61
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java da8a4662089d14e485377a51af9eed88917fd2d8
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 0fdb57db0f630a4ce44c81381bf6f02a0d4fb765
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommand.java 0f9b5d89773ba946a296e85929b8d8b8b7ea2bd7
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java 40bd0f334a19ef38f7465fd40916c286f92cb1ce
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GetCommand.java f09174e08527cbcfe397c30a6206a21dd7c96bfb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ImportDataCommand.java 23084059dc19f1e5da83b319cf8f458bcc230e86
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LocateEntryCommand.java f4caf139283ead6878b4ffa20e56ac309e9e9749
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PutCommand.java 3571f6de1379dfeecdcb73a6804f763f67f35894
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java 3c039b3a70cf7b38b4f4af77079f0b5d6a39caf5
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java 12be62e856f78a3489f361278e9461d445e56905
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 1d028524ecd6c737fb53f54dcf5c6d5187f15477
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java 0492997533b88bbb73dc7e87d1f641b98f53f684
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 00420ccf341246ca740c3be0b7ab062fb70ecaaf
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java 729c68b1bf5d2a0e2b8fc634dbf42c989a68eb40
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java bf699be52da630207b542c542aa33ae9798e4000
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 59958905160ff96fc06a16423c3fb9f801c5b324
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java c53b0382732a29e64b403e8eb0f914e19de79b84
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java b2e30f264a76e88e397488609edef135b4a115c2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java cfb496069ca95abc67dc6fe84e6eb2f430c09f2c
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 78097d2f8d8d5a67ea7fae57d9147e37fc905d25
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java 40bfe45396017b9a18a38db5eed2d3eed2fbe0f2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java a3ee2c8b808e0d4906d89d0eec4e8ab249a3f642
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java ceb8882954e2ad0d1a638e96945976726e728b06
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java 4497c7fd48349f288f7a4a99ea283aba9f352f91
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 08e1a29ba4718c936fd953bee87c071a353ce1a1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java a4da48f8bc5504df9323be809b1e1145947a9cd7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java bd99e6c261f5c44a74dfc7d8b70e414a29502ed0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 8d52b8853994e7c2788a3a90de6be3f516358606
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java 6f894cf8c9afad5f8f61df40e31ff8a23e5f3596
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java 5437f71a3de19bdc74501e5bd0939a6e4cb52ddd
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java 0ed27a0244c97ea99e1d2e7c54e91fc80b0eeff1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java bae07b456d9d12bc9d4d10ea0af03e63248f6e2b
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java 1074de585dda9963208a20ac8d28c06a8be5d614
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java cd07e71ee7fed541473596067ad7eb636bc17637
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java de5a4597cd609d20afdc86fa3adae72d2dae1f50
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java bf7badb0fb3d2f5fae87013e1fac9dc4a5e25df2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 50fb9cd18d45e82a7f04e61aa8dbdbf2b6b3a419
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java a37263f11cefbe317d2a24989256d7d5559cf599
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java 1ba5fed2020652b8da58c652640c97cbfcf9dd9f
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java f5e31df988f5955d2fbeef5269a7729ec97c9d03
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 41c89235dbb6b85f4ab69511ad4dba46262a5cf3
>
>
> Diff: https://reviews.apache.org/r/62189/diff/1/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62189/#review185024
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Sept. 8, 2017, 4:28 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62189/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 4:28 p.m.)
>
>
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2817: consolidate authorize(*) methods
>
> * this is just a changeset that removed those authorizeCluster*, authorizeData* authorizeRegion* functions. They made the interface unnecessaily large, and doesn't really offer much value. I prefer to see authorize(DATA, READ, regionname), insteadof authorizeRegionRead(*) in the code so that it's clear what exactly is the permssion needed. This also makes the further change/update to the interface easier to manage.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/execute/Function.java 25ba4e37f579e1f222439ef19c223111faabda61
> geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 0b4e7f9de38b234742a427b55ceda2e63d93d83e
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java f895b964794f99127f1f0c9564f3f85213e0af22
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 184aa36fc5509285001155e20d846cc717544d2f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java 610af436cd96b0663d69915d8a1b37549e4f7bc2
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java d7a1b2b0183405142d524c1d91433eb01ac3e9f6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java 03e798c579e6c26e3aa7cb9a522f8af514f60ce3
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java 2be4724bc2b2b6d472558cdecddba982da032a08
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java cdbab8047558234bd25aa6155a7603a62d697d03
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java c8b794a9b0b4c223e6391a8e7f63aa0747943417
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java baa2f3f480ce4bea522ea520e86328384cfd2d23
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java 08f02642e937abf3b0e2557cd06c8264ac0dee32
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java 53db561963d7b9abbe86e0dbf7e73613f6a5ceef
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java a3b061f761a9f1e6a7302b5e8dc31e9a98a9959c
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java 73eff40c34f6fe882ec1e21168e522ae9ced2736
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java 47684aa2fb5d8ec0190f0e047a627c08e77598f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java 26d5d3f31a6b0cf2e2ff1477a2e5e3449fd5453d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java 8c3bb381fe6e2e9018aaf8c333a3ab0c26127c27
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java 62644eb109f661a00c2c4df06e96c8d7a4f8d33f
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java e214ce16e4be1f044f40f44308435eec43d1c8ca
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java aacfc6dccd6385ac39a9c2b65ecf6f7456bba704
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java 0449447e3b9e8bd202ed7d14f35d258034f4c861
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java 9f970a59961c8d10c498f8db6f8cb403036d9f96
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java 3952b0f98965c3a56d1c003454c323a55f295f0b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java 202d91fc8bbfcd012a7b6c344b3ef39f63b7b81d
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java 27f8cc564c163a2d1c8448f0c7acb411993e5fc1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java 60870d7eb04067b3ff5540597c403b9a9b491c65
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java 8f65b9bd0bdaef161d230fd1ecf47b7efa1be8cf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java f8cd57fdfc6cd8aa939d314e94d3c1f38fe90521
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java 1bf4955021104986b7c6ac5bc9e6fa1b1085b83b
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java 3a8f0db633384f5cdb65405c3bf21d53bed30a0e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java a1cf93f15733da95e9b1aea8b709b5d4166b8559
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java 111f234130ae4e0733d634714765ebe3c998b49e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java c64bc6979da6049c901b34d8aaf0d66a1d26336a
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java 82e2f0d7ab79e87bec81da29610016ea8f5eafe6
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java 5f6ab9b08fa0873b8dbc7fcd755b1857ffe3770e
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java 2daf755ab200d84f0b7760224060439d9e3518f1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java 25badd328a5d7edafb81fd3402ebcc47301983d1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java e4485b469858881486a588adc627181d093c9949
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java 1af283bbfefee7ff4f855429139aae20076c2d78
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java 035a953fd40d90e5c49f7c53bb997637d3d24c61
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java da8a4662089d14e485377a51af9eed88917fd2d8
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 0fdb57db0f630a4ce44c81381bf6f02a0d4fb765
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommand.java 0f9b5d89773ba946a296e85929b8d8b8b7ea2bd7
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java 40bd0f334a19ef38f7465fd40916c286f92cb1ce
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GetCommand.java f09174e08527cbcfe397c30a6206a21dd7c96bfb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ImportDataCommand.java 23084059dc19f1e5da83b319cf8f458bcc230e86
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LocateEntryCommand.java f4caf139283ead6878b4ffa20e56ac309e9e9749
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PutCommand.java 3571f6de1379dfeecdcb73a6804f763f67f35894
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java 3c039b3a70cf7b38b4f4af77079f0b5d6a39caf5
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java 12be62e856f78a3489f361278e9461d445e56905
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 1d028524ecd6c737fb53f54dcf5c6d5187f15477
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java 0492997533b88bbb73dc7e87d1f641b98f53f684
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 00420ccf341246ca740c3be0b7ab062fb70ecaaf
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java 729c68b1bf5d2a0e2b8fc634dbf42c989a68eb40
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java bf699be52da630207b542c542aa33ae9798e4000
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 59958905160ff96fc06a16423c3fb9f801c5b324
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java c53b0382732a29e64b403e8eb0f914e19de79b84
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java b2e30f264a76e88e397488609edef135b4a115c2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java cfb496069ca95abc67dc6fe84e6eb2f430c09f2c
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 78097d2f8d8d5a67ea7fae57d9147e37fc905d25
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java 40bfe45396017b9a18a38db5eed2d3eed2fbe0f2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java a3ee2c8b808e0d4906d89d0eec4e8ab249a3f642
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java ceb8882954e2ad0d1a638e96945976726e728b06
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java 4497c7fd48349f288f7a4a99ea283aba9f352f91
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 08e1a29ba4718c936fd953bee87c071a353ce1a1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java a4da48f8bc5504df9323be809b1e1145947a9cd7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java bd99e6c261f5c44a74dfc7d8b70e414a29502ed0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 8d52b8853994e7c2788a3a90de6be3f516358606
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java 6f894cf8c9afad5f8f61df40e31ff8a23e5f3596
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java 5437f71a3de19bdc74501e5bd0939a6e4cb52ddd
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java 0ed27a0244c97ea99e1d2e7c54e91fc80b0eeff1
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java bae07b456d9d12bc9d4d10ea0af03e63248f6e2b
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java 1074de585dda9963208a20ac8d28c06a8be5d614
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java cd07e71ee7fed541473596067ad7eb636bc17637
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java de5a4597cd609d20afdc86fa3adae72d2dae1f50
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java bf7badb0fb3d2f5fae87013e1fac9dc4a5e25df2
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 50fb9cd18d45e82a7f04e61aa8dbdbf2b6b3a419
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java a37263f11cefbe317d2a24989256d7d5559cf599
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java 1ba5fed2020652b8da58c652640c97cbfcf9dd9f
> geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java f5e31df988f5955d2fbeef5269a7729ec97c9d03
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 41c89235dbb6b85f4ab69511ad4dba46262a5cf3
>
>
> Diff: https://reviews.apache.org/r/62189/diff/1/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>