You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 04:51:05 UTC
[jira] [Commented] (BEAM-2147) Re-enable UsesTimersInParDo tests
for DataflowRunner
[ https://issues.apache.org/jira/browse/BEAM-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002023#comment-16002023 ]
ASF GitHub Bot commented on BEAM-2147:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2988
[BEAM-2147] Re-enable UsesTimersInParDo tests on Dataflow, by fixing TestDataflowRunner and PAssert
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam DataflowRunner-timers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2988
----
commit 1a4910b1b73330094a1e1033ffde20e41b7024e3
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-05-09T03:07:29Z
Allow any throwable in PAssert to constitute adequate failure
Currently, some PAssert tests require an AssertionError to be thrown. This
succeeds on all runners only because many gratuitously throw AssertionError
when they don't actually know that an assertion has failed.
The spec is just that a pipeline has to fail. We don't have a good enough story
around exception propagation to have such a strict - and fake - spec. And it
isn't cross-language anyhow FWIW, looking forward to the possibility of running
a PAssert in a pipeline combining multiple SDK harnesses.
commit 01fd6cc568a7af05f260613197165bfc2f8ee86b
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-04-30T23:08:48Z
TestDataflowRunner: throw AssertionError only when assertion known failed
It is quite confusing to receive an assertion error when in fact the pipeline
has crashed because of user error interacting with e.g. timers.
commit 898731b19a630ffc8ec8062acb0fd53bd4995635
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-02-14T22:54:11Z
Re-enable UsesTimersInParDo tests in Dataflow runner
----
> Re-enable UsesTimersInParDo tests for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-2147
> URL: https://issues.apache.org/jira/browse/BEAM-2147
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> These are disabled currently because of bugs in the {{TestDataflowRunner}}'s diagnosis of whether something is an {{AssertionError}} or some other {{RuntimeException}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)