[GitHub] [arrow] vibhatha commented on a diff in pull request #13741: ARROW-17247: [C++][Docs] Include visibilty to ExecPlan APIs in Acero Docs

[GitBox <gi...@apache.org>]

vibhatha commented on code in PR #13741:
URL: https://github.com/apache/arrow/pull/13741#discussion_r933670953


##########
cpp/src/arrow/compute/exec.h:
##########
@@ -174,6 +174,10 @@ class ARROW_EXPORT SelectionVector {
 /// TODO: Datum uses arrow/util/variant.h which may be a bit heavier-weight
 /// than is desirable for this class. Microbenchmarks would help determine for
 /// sure. See ARROW-8928.
+
+/// \addtogroup execnode-components

Review Comment:
   This builds perfectly fine. And displays right. I didn’t add it because I assumed it followed by the header file import. When the corresponding headers included the build breaks. I didn’t investigate deeper yet. But removing the group and header import was still fine. 
   
   I guess we could just include the group only, without the header?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org