You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/07/28 11:20:16 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
GitHub user tzolov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/172
ZEPPELIN-70: Add PostgreSQL Interpreter
modified: conf/zeppelin-site.xml.template
modified: pom.xml
new file: postgresql/pom.xml
new file: postgresql/src/main/java/org/apache/zeppelin/postgresql/PostgreSqlInterpreter.java
new file: postgresql/src/test/java/org/apache/zeppelin/postgresql/PostgreSqlInterpreterTest.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-70
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit da1c2a6bd7720d6cc92e06d9a07e216fa7e54886
Author: tzolov <ch...@gmail.com>
Date: 2015-07-28T09:09:09Z
ZEPPELIN-70: Add PostgreSQL Interpreter
modified: conf/zeppelin-site.xml.template
modified: pom.xml
new file: postgresql/pom.xml
new file: postgresql/src/main/java/org/apache/zeppelin/postgresql/PostgreSqlInterpreter.java
new file: postgresql/src/test/java/org/apache/zeppelin/postgresql/PostgreSqlInterpreterTest.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-128168245
Thank you for taking care!
According to http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled Mochito licence should not be added, as we do not package/distribute it on the release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-129103629
Thanks! Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-127982959
I've added the PostgreSQL JDBC and Mockito license statements to Zeppelin LICENSE file. I've applied the same syntax structure used in [Ambari LICENSE](https://github.com/apache/ambari/blob/trunk/LICENSE.txt) and [HIVE LICENSE](https://github.com/apache/hive/blob/master/LICENSE).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-127442232
New dependency brought by this PR is under Postgres license, which seems to be compatible http://www.apache.org/legal/resolved.html#category-a
So AFAIK at lease LICENCE file have to be updated http://www.apache.org/dev/licensing-howto.html#permissive-deps
Is that correct, or am I missing something? \cc @Leemoonsoo @rvs for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-127947742
@bzz , @Leemoonsoo , @rvs,
i've looked around and it appears that many ASF projects inline the 3rd party license statements in the main LICENSE. For example [Ambari](https://github.com/apache/ambari/blob/trunk/LICENSE.txt) or [HIVE](https://github.com/apache/hive/blob/master/LICENSE). Note that Hive already lists PostgreSQL (in the bottom).
I guess we need to list the Mockito (MIT) license as well.
Please, let me know if it is ok with you to amend the Zeppelin LICENSE with PostgreSQL and Mockito paragraphs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-127617675
FYI, the PostgreSQL JDBC driver (used in this interpreter) uses the same license as the PostgreSQL: https://jdbc.postgresql.org/about/license.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-127615197
@bzz, indeed the postgresql is amongst the licenses approved by ASF.
So if i understand the instructions correct i need to add the postgresql license (http://opensource.org/licenses/postgresql) file to the interpreter's source tree and then add a pointer with notice in the Zeppelin LICENSE file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-128349465
Thank you! Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/172#issuecomment-128176962
@bzz got it. Just removed it from the LICENSE and squashed the change into the last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---