[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' …

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' …
URL: https://github.com/apache/phoenix-connectors/pull/7#discussion_r342139331
 
 

 ##########
 File path: phoenix-hive/src/test/java/org/apache/phoenix/hive/query/PhoenixQueryBuilderTest.java
 ##########
 @@ -170,4 +175,67 @@ public void testBuildQueryWithNotNull() throws IOException {
                         "\"" + COLUMN_DATE + "\" is not null ",
                 BUILDER.buildQuery(jobConf, TABLE_NAME, readColumnList, searchConditions));
     }
+
+    @Test
+    public void testBuildQueryWithBigintColumns() throws IOException {
+        final String COLUMN_BIGINT = "Column_Bigint";
+        final String COLUMN_INT = "Column_Int";
+        final String COLUMN_BIGINT2 = "Column_Bigint2";
+        final String tableName = "TEST_TABLE";
+        final String expectedQueryPrefix = "select /*+ NO_CACHE  */ * from " + tableName
+          + " where ";
+
+        JobConf jobConf = new JobConf();
+        List<String> readColumnList = Collections.emptyList();
+
+        {
 
 Review comment:
   Can you get rid of the curly-braces? I think it's fine to have these three clauses in this one test method, but, if you'd like to have them more logically separated, separate test methods would also be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services